Wrong committee attendance data for MK Michael Malkieli

[shevyk]

MK Michael Malkieli does not appear as having attended committee meetings even though his attendance is recorded in the published protocol. See, for example: https://oknesset.org/committee/meeting/13483/

[alonisser]

@shevyk this is because #133 He can't be in attendance if he is not registered as committee member

[OriHoch]

thanks @alonisser - when I moved the committees scrapers code to knesset-data I don't remember any check of committee memeber.. I'll check again, maybe I missed something

[alonisser]

I don't think there was any, at least for a very long time, the thing is the attendance scraper checks vs the committee members so if the committee members are not updated (BY ADMINISTRATOR) the attendance is wrong

On Tue, Apr 4, 2017 at 12:48 PM Ori Hoch ***@***.***> wrote: thanks @alonisser <https://github.com/alonisser> - when I moved the committees scrapers code to knesset-data I don't remember any check of committee memeber.. I'll check again, maybe I missed something — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXlcAV2Ny18T549lNPOLCKoa9X6bqk6ks5rshH0gaJpZM4Mw5Jw> .

-- Alon Nisser twitter:@alonisser <https://twitter.com/alonisser> Facebook <https://www.facebook.com/alonisser> Tech Blog: https://medium.com/@alonisser/ *Personal Blog:*degeladom.wordpress.com Tel:972-54-6734469

[OriHoch]

ok, this is stupid 🤷‍♂️

he had an extra space after his name

"מיכאל מלכיאלי "

• I edited him on Open Knesset admin - and removed the extra space, so he should appear in future meetings from now on
• Fixed the scraper that matches attending members to prevent this and similar problems (fixed in v1.8.0)

@alonisser @maryLoi @shevyk

regarding old meetings - I think they will have to be fixed by hand, or in bulk reparse all committee meetings

[shevyk]

Thanks Ori. I think reparsing makes more sense, but only for the last moshav since he joined in November. On Apr 13, 2017 12:36 PM, "Ori Hoch" <[email protected]> wrote: ok, this is stupid 🤷‍♂️ he had an extra space after his name "מיכאל מלכיאלי " - I edited him on Open Knesset admin - and removed the extra space, so he should appear in future meetings from now on - Fixed the scraper that matches attending members to prevent this and similar problems (fixed in v1.8.0 <https://github.com/hasadna/knesset-data-python/releases/tag/untagged-7147cf2c742c5d6b5143> ) @alonisser <https://github.com/alonisser> @maryLoi <https://github.com/maryLoi> @shevyk <https://github.com/shevyk> regarding old meetings - I think they will have to be fixed by hand, or in bulk reparse all committee meetings — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMHcTVtqOwDT0zxqMYgi2tryqfzOP40sks5rveyngaJpZM4Mw5Jw> .

[OriHoch]

it's fixed, I rescraped all meetings of the last moshav
also, made sure all MKs don't have spare spaces..