Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize code to pass linter checks #445

Merged
merged 95 commits into from
Mar 5, 2024
Merged

Modernize code to pass linter checks #445

merged 95 commits into from
Mar 5, 2024

Conversation

jace
Copy link
Member

@jace jace commented May 11, 2023

Also drop the obsolete html5print dependency.

jace and others added 30 commits May 11, 2023 19:00
@jace
Upgrades for SQLAlchemy 2.0; additional linters; drop obsolete html5p…
eb84929 
…rint dependency
@jace
Fix all linter-identified issues
9adf024
@jace
Support pytest without wrapping shell script
ba71efa
@jace
Add ALLOWED_ORIGINS to config sample
f7f0d1a
@jace
Remove custom endpoint names from views
9ca7851
@jace
Use status code 422 instead of 402
ea6a09a
@jace
Fix import
79ba9c7
@jace
Upgrade JavaScript (incomplete, still has webpack build errors)
5675fd6
@jace
Now left with only unused var errors, and one undefined reference
f648dc9
@jace
Webpack is now building, but Baseframe can't parse the new manifest.j…
edb42ba 
…son format
@jace
Webpack assets now require the .js extension
ebc646a
@jace
Merge branch 'main' into linter-fixes
d125066
@jace
Merge branch 'main' into linter-fixes
91b46f9
@jace
Add DeepSource config
553efd2
@jace
ASSET_BASE_PATH is no longer required with new Webpack
d5f0f78
@jace
Use psycopg3 for tests
e496c50
@jace
Remove db.Model from base class in models
94d4b28
@jace
Specify Ractive.transitions.fly on Ractive init
e1dbe73
@vidya-ram
Change ractive to version 0.8.0
1e4efb3
@vidya-ram
Merge branch 'linter-fixes' of https://github.com/hasgeek/boxoffice i…
5431f46 
…nto linter-fixes
@jace
Remove unnecessary type ignores
9452063
@jace
Use backref from Coaster
62d4267
@vidya-ram
Add css build to webpack
326cddf
@vidya-ram
Merge branch 'linter-fixes' of https://github.com/hasgeek/boxoffice i…
608bfe9 
…nto linter-fixes
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6365544 
for more information, see https://pre-commit.ci
@jace
Relocate enums into a single file, move some added properties, use as…
8e3f438 
…set_path
@jace
Use mapped_column instead of Column
5160133
@jace
Replace all relationship backrefs with back_populates
7aa441b
@jace
Move ItemCollection.net_sales report within class and use SQLAlchemy …
530e6ae 
…query construct
@jace
Convert sales_by_date SQL to SQLAlchemy query
c7472ba
jace and others added 21 commits August 7, 2023 16:09
@jace
Merge branch 'main' into linter-fixes
bd321ae
@jace
Merge branch 'main' into linter-fixes
d598eed
@miteshashar
Ignore pyenv's .python-version file
5618618
@miteshashar
Merge branch 'main' into linter-fixes
cab74f4
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
56a1d56 
for more information, see https://pre-commit.ci
@miteshashar
Add sample.env
9fe7f4e
@miteshashar
Correct LASTUSER_COOKIE_DOMAIN in sample.env
e9c69c8
@miteshashar
Change the path for ticket search API endpoint from /admin/o/<org>/it…
b392d88 
…ems to /admin/o/<org>/tickets
@miteshashar
Discount policy endpoint expects applicable tickets in the ticket(s) …
3c7a8c6 
…parameter - renamed item(s) parameter to ticket(s)
@jace
Work-in-progress commit for type annotations in line item discounter
0b96770
@jace
Merge branch 'main' into linter-fixes
fd32482
@jace
Merge branch 'main' into linter-fixes
fc646ac
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
36dee28 
for more information, see https://pre-commit.ci
@jace
Merge branch 'main' into linter-fixes
b5e4016
@jace
Upgrade to Python 3.11 (Mypy is still failing)
106f639
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6c5f0e7 
for more information, see https://pre-commit.ci
@jace
Fix imports
ee875e8
@jace
Use a cast to allow subtraction
c6cc7ba
@jace
Remove beartype (breaks Mypy again); use generics
313c0f6
@jace
Typing issues all resolved, I hope
d3864c3
@jace
Rename set_queries to __post_init__
211f5fe
@jace
Copy link
Member Author

jace commented Mar 5, 2024

Finally passing all pre-commit checks.

@jace
Copy link
Member Author

jace commented Mar 5, 2024

This still has some way to go before Boxoffice can be merged into Funnel:

  1. The dependencies need to be a subset of what Funnel uses
  2. The User and Organization models should not have any additional fields, as Funnel's Account won't be getting them
  3. The scripts/ folder needs to be dropped, so whatever useful functionality it still has needs to be moved into a CLI command

@jace jace merged commit 8dc4c1e into main Mar 5, 2024
9 of 10 checks passed
@jace jace deleted the linter-fixes branch March 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jace @vidya-ram @anishTP @miteshashar