-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add a protocol document for publishBlockStream
#267
Conversation
d498805
to
a062c6f
Compare
publishBlockStream
.publishBlockStream
8750516
to
015a11a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I've already reviewed the design, so don't have any comments on it. Left a few formatting suggestions.
* Added a new document in `docs/Protocol` for `publishBlockStream`. * Included a first pass protocol definition. * Note this is in general informal language; not Estelle, SDL, LOTOS, or other highly formal language. Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]> Signed-off-by: Joseph Sinclair <[email protected]>
dfc7cc7
to
5e58a32
Compare
* Changed definition list to work within github limitations. * Added an Abstract section to reduce confusion. * Added a readme file to describe items in the protocol folder * Added a reliability note to explain the cautious nature of the protocol. Signed-off-by: Joseph Sinclair <[email protected]>
5e58a32
to
9ffb8e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm, looks good 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 99.78% 99.78%
Complexity 259 259
=========================================
Files 52 52
Lines 938 938
Branches 64 64
=========================================
Hits 936 936
Misses 2 2 |
docs/Protocol
forpublishBlockStream
.or other highly formal language.
Fixes #120