Cherrypick - Extract and Log Contract Revert Reason (#1043) #1070

AlfredoG87 · 2023-04-14T23:57:53Z

Description:
Cherry-picks:
#1043

codecov-commenter · 2023-04-15T00:04:03Z

Codecov Report

Patch coverage: 52.94% and project coverage change: -0.20 ⚠️

Comparison is base (72212d7) 74.63% compared to head (7928625) 74.43%.

❗ Current head 7928625 differs from pull request most recent head 5c60128. Consider uploading reports for the commit 5c60128 to get more accurate results

Additional details and impacted files

@@               Coverage Diff                @@
##           release/0.21    #1070      +/-   ##
================================================
- Coverage         74.63%   74.43%   -0.20%     
================================================
  Files                30       30              
  Lines              2030     2046      +16     
  Branches            386      390       +4     
================================================
+ Hits               1515     1523       +8     
- Misses              410      417       +7     
- Partials            105      106       +1

Impacted Files	Coverage Δ
packages/relay/src/lib/constants.ts	`100.00% <ø> (ø)`
packages/relay/src/lib/errors/SDKClientError.ts	`58.82% <0.00%> (-3.68%)`	⬇️
packages/relay/src/lib/eth.ts	`83.33% <12.50%> (-0.94%)`	⬇️
packages/relay/src/lib/clients/mirrorNodeClient.ts	`94.16% <100.00%> (+0.16%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This PR adds a new mirror node request method, to get transaction by transaction id. This way we can get the contract revert reason. Log this error in the relay log. This makes debugging easier as developers won't have to query manually the mirror-node for every failed test. Signed-off-by: georgi-l95 <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]>