Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the abort controller to cancel requests. (#1067) #1077

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Apr 15, 2023

Description:
Cherry pick #1067
Uses the axios controller abort to cancel requests on timeouts.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC self-assigned this Apr 15, 2023
@Nana-EC Nana-EC added bug Something isn't working P1 labels Apr 15, 2023
@Nana-EC Nana-EC added this to the 0.21.1 milestone Apr 15, 2023
Uses the axios controller abort to cancel requests on timeouts.

---------

Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC force-pushed the cherry-pick-1067-to-0-21 branch from 0ab496d to f9bc8e9 Compare April 15, 2023 02:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (80eaa25) 74.69% compared to head (966fccf) 74.79%.

❗ Current head 966fccf differs from pull request most recent head 7a7f34f. Consider uploading reports for the commit 7a7f34f to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.21    #1077      +/-   ##
================================================
+ Coverage         74.69%   74.79%   +0.09%     
================================================
  Files                30       30              
  Lines              2067     2071       +4     
  Branches            394      396       +2     
================================================
+ Hits               1544     1549       +5     
+ Misses              417      416       -1     
  Partials            106      106              
Impacted Files Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 94.25% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK already!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlfredoG87 AlfredoG87 merged commit 1897b9c into release/0.21 Apr 15, 2023
@AlfredoG87 AlfredoG87 deleted the cherry-pick-1067-to-0-21 branch April 15, 2023 03:52
@natanasow natanasow mentioned this pull request Dec 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants