-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script executing execution api tests #1621
Script executing execution api tests #1621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, some good-to-have fixes and we're ready 🚀
a47925c
to
76c148c
Compare
1b1345e
to
ee7093e
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
=======================================
Coverage 76.65% 76.65%
=======================================
Files 39 39
Lines 2913 2913
Branches 584 584
=======================================
Hits 2233 2233
Misses 499 499
Partials 181 181 ☔ View full report in Codecov by Sentry. |
4fb240f
to
03e7f40
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
7ee56de
to
4b3d291
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, some suggestions TBD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Some suggestions
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
Left some non blocking comment which I would like addressed but can be done in a follow up separate PR if desired
4c1bb3d
to
023576c
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
023576c
to
f35aa56
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
* Draft of script executing execution api tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to make it more readable and modular Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes PR comments Signed-off-by: Konstantina Blazhukova <[email protected]> * Resolves conflict Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes for some transaction methods and sendRawTransaction Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes package-lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Tries to fix package-lock.json conflicts Signed-off-by: Konstantina Blazhukova <[email protected]> * Package lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to handle different transaction for getTransactionByHash Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script for all methods and optimizes it Signed-off-by: Konstantina Blazhukova <[email protected]> * Sets nonce via getTransactionCount Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors main to make it more readable Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds execution api repo as dependency Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to test file Signed-off-by: Konstantina Blazhukova <[email protected]> * Deletes script Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds command for executing new tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds conformity tests to github workflow Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds new dependencies to package-lock Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes typo in package.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Changes github workflow name Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds comments and docs; Takes bytecode from json Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script name for conformity tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes redundant variable; moves variable to const Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds specifig tag to execution apis repo Signed-off-by: Konstantina Blazhukova <[email protected]> * Replaces file name string with constant variables Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds more informative variables for request.param checks Signed-off-by: Konstantina Blazhukova <[email protected]> * Combines sendrawTransaction checks Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: ebadiere <[email protected]>
* Draft of script executing execution api tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to make it more readable and modular Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes PR comments Signed-off-by: Konstantina Blazhukova <[email protected]> * Resolves conflict Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes for some transaction methods and sendRawTransaction Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes package-lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Tries to fix package-lock.json conflicts Signed-off-by: Konstantina Blazhukova <[email protected]> * Package lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to handle different transaction for getTransactionByHash Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script for all methods and optimizes it Signed-off-by: Konstantina Blazhukova <[email protected]> * Sets nonce via getTransactionCount Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors main to make it more readable Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds execution api repo as dependency Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to test file Signed-off-by: Konstantina Blazhukova <[email protected]> * Deletes script Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds command for executing new tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds conformity tests to github workflow Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds new dependencies to package-lock Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes typo in package.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Changes github workflow name Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds comments and docs; Takes bytecode from json Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script name for conformity tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes redundant variable; moves variable to const Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds specifig tag to execution apis repo Signed-off-by: Konstantina Blazhukova <[email protected]> * Replaces file name string with constant variables Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds more informative variables for request.param checks Signed-off-by: Konstantina Blazhukova <[email protected]> * Combines sendrawTransaction checks Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: ebadiere <[email protected]>
* Draft of script executing execution api tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to make it more readable and modular Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes PR comments Signed-off-by: Konstantina Blazhukova <[email protected]> * Resolves conflict Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes for some transaction methods and sendRawTransaction Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes package-lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Tries to fix package-lock.json conflicts Signed-off-by: Konstantina Blazhukova <[email protected]> * Package lock.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to handle different transaction for getTransactionByHash Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script for all methods and optimizes it Signed-off-by: Konstantina Blazhukova <[email protected]> * Sets nonce via getTransactionCount Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors main to make it more readable Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds execution api repo as dependency Signed-off-by: Konstantina Blazhukova <[email protected]> * Refactors script to test file Signed-off-by: Konstantina Blazhukova <[email protected]> * Deletes script Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds command for executing new tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds conformity tests to github workflow Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds new dependencies to package-lock Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes typo in package.json Signed-off-by: Konstantina Blazhukova <[email protected]> * Changes github workflow name Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds comments and docs; Takes bytecode from json Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes script name for conformity tests Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes redundant variable; moves variable to const Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds specifig tag to execution apis repo Signed-off-by: Konstantina Blazhukova <[email protected]> * Replaces file name string with constant variables Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds more informative variables for request.param checks Signed-off-by: Konstantina Blazhukova <[email protected]> * Combines sendrawTransaction checks Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
Description:
The goal of this PR is to introduce a script which runs whenever a PR is created and tests if we conform to the JSON RPC Specification
Related issue(s):
Fixes #
#1475
Notes for reviewer:
Checklist