Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for update token info #462

Closed
wants to merge 1 commit into from
Closed

Conversation

lukelee-sl
Copy link
Member

Signed-off-by: lukelee-sl [email protected]

Description:
Add tests for updateToken.

The tests cannot be executed as they depend on completion of the following pr in services: hashgraph/hedera-services#3738

Updated HederaTokenService.sol and IHederaTokenService.sol to add call for performing the update. The corresponding .json files have not yet been updated awaiting completion of the pr referenced above.

Related issue(s):

Fixes #410

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lukelee-sl lukelee-sl self-assigned this Aug 22, 2022
@lukelee-sl lukelee-sl marked this pull request as draft August 22, 2022 17:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #462 (e000518) into main (f87403b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files          12       12           
  Lines         922      922           
  Branches      143      143           
=======================================
  Hits          705      705           
  Misses        165      165           
  Partials       52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nana-EC Nana-EC added this to the 0.12.0 milestone Nov 1, 2022
@Nana-EC Nana-EC modified the milestones: 0.12.0, 0.13.0 Nov 15, 2022
@lukelee-sl
Copy link
Member Author

This issue can be closed as it is a duplicate of pr #527

@lukelee-sl lukelee-sl closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add htsPrecompile acceptance test coverage for update token methods
3 participants