HTS precompile token key management tests #464

Ivo-Yankov · 2022-08-23T10:47:36Z

Description:
Adds tests for getTokenKey and updateTokenKeys.
Applies changes from PR #524
Adds a new acceptance test suite - htsPrecompile_v2 in order to reduce the size of BaseHTS.sol so that the bytecode doesn't exceed 24kb.

Related issue(s):

Fixes #409
Fixes #521

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <[email protected]>

Signed-off-by: Ivo Yankov <[email protected]> # Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts # packages/server/tests/contracts/HederaTokenService.sol # packages/server/tests/contracts/IHederaTokenService.sol

packages/server/tests/acceptance/htsPrecompile.spec.ts

Signed-off-by: Ivo Yankov <[email protected]>

Signed-off-by: Nana Essilfie-Conduah <[email protected]>

# Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts # packages/server/tests/contracts/BaseHTS.json # packages/server/tests/contracts/BaseHTS.sol # packages/server/tests/contracts/HederaTokenService.json # packages/server/tests/contracts/HederaTokenService.sol # packages/server/tests/contracts/IHederaTokenService.json # packages/server/tests/contracts/IHederaTokenService.sol

Signed-off-by: Ivo Yankov <[email protected]>

codecov-commenter · 2022-09-12T14:41:07Z

Codecov Report

Base: 76.67% // Head: 76.88% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (fcb283e) compared to base (bed9aa9).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   76.67%   76.88%   +0.20%     
==========================================
  Files          12       12              
  Lines         926      943      +17     
  Branches      145      149       +4     
==========================================
+ Hits          710      725      +15     
- Misses        164      169       +5     
+ Partials       52       49       -3

Impacted Files	Coverage Δ
packages/relay/src/lib/constants.ts	`100.00% <0.00%> (ø)`
packages/relay/src/lib/eth.ts	`84.71% <0.00%> (+0.06%)`	⬆️
packages/relay/src/lib/errors/JsonRpcError.ts	`77.77% <0.00%> (+2.77%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Ivo Yankov <[email protected]>

# Conflicts: # packages/server/tests/contracts/BaseHTS.json

Signed-off-by: Ivo Yankov <[email protected]>

Nana-EC

LG
Please update PR descriptions

package-lock.json

tools/hardhat-example/hardhat.config.js

Signed-off-by: Ivo Yankov <[email protected]>

# Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts # packages/server/tests/contracts/BaseHTS.json # packages/server/tests/contracts/BaseHTS.sol # packages/server/tests/contracts/HederaTokenService.sol # packages/server/tests/contracts/IHederaTokenService.sol

Signed-off-by: Ivo Yankov <[email protected]>

Nana-EC

LG

# Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts # packages/server/tests/contracts/BaseHTS.json # packages/server/tests/contracts/BaseHTS.sol # packages/server/tests/contracts/IHederaTokenService.json # packages/server/tests/contracts/IHederaTokenService.sol

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov · 2022-09-19T07:04:24Z

The HTS Precompile tests in their current state are very unstable and require a refactor. The bytecode of BaseHTS contract has become larger than 25kb and it cannot be deployed because of the EVM limit of 24kb.

Signed-off-by: Ivo Yankov <[email protected]>

lukelee-sl · 2022-09-19T14:59:39Z

package.json

@@ -25,6 +25,7 @@
        "acceptancetest:erc20": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@erc20' --exit",
        "acceptancetest:htsprecompile": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@htsprecompile' --exit",
        "acceptancetest:htsprecompilev1": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@htsprecompilev1' --exit",
+        "acceptancetest:htsprecompilev2": "ts-mocha packages/server/tests/acceptance/index.spec.ts  -g '@htsprecompilev2' --exit",


the -g flag is a grep and thus -g '@htsprecompile' will match three acceptance tests (acceptancetest:htsprecompile, acceptancetest:htsprecompilev1, acceptancetest:htsprecompilev2).

Nana-EC

Let's not use a v2 as it gives a different meaning
Provided suggestions

.github/workflows/acceptance.yml

packages/server/tests/contracts/contracts_v2/BaseHTS.sol

Signed-off-by: Ivo Yankov <[email protected]>

Nana-EC

Some contract function dupes to fix

packages/server/tests/contracts/TokenManagementContract.sol

Signed-off-by: Ivo Yankov <[email protected]>

sonarqubecloud · 2022-09-20T14:43:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Nana-EC

LG

Nana-EC · 2022-09-20T17:57:49Z

packages/server/tests/contracts/TokenCreateContract.sol

+
+import "./TokenCreate.sol";
+
+contract TokenContractContract is TokenCreate {


Can fix this later

Suggested change

contract TokenContractContract is TokenCreate {

contract TokenCreateContract is TokenCreate {

Ivo-Yankov added 4 commits August 23, 2022 12:58

test: add placeholder tests for key management

cb1b198

Signed-off-by: Ivo Yankov <[email protected]>

chore: revert unnecessary changes

74f6382

Signed-off-by: Ivo Yankov <[email protected]>

chore: revert unnecessary changes

f6ec88f

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov changed the title ~~409 hts precompile token key tests~~ HTS precompile token key management tests Aug 23, 2022

Nana-EC assigned Ivo-Yankov Aug 23, 2022

Nana-EC added enhancement New feature or request limechain P2 labels Aug 23, 2022

Nana-EC requested review from natanasow, georgi-l95, lukelee-sl and shemnon August 23, 2022 14:43

Nana-EC reviewed Aug 23, 2022

View reviewed changes

packages/server/tests/acceptance/htsPrecompile.spec.ts Outdated Show resolved Hide resolved

packages/server/tests/acceptance/htsPrecompile.spec.ts Outdated Show resolved Hide resolved

chore: update comment

2023a21

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov marked this pull request as draft August 24, 2022 11:52

Nana-EC added this to the 0.8.0 milestone Aug 24, 2022

Ivo-Yankov and others added 5 commits September 5, 2022 14:49

Merge branch 'main' into 409-hts-precompile-token-key-tests

8acf39f

test: enable pending tests

ebcc0a7

Signed-off-by: Ivo Yankov <[email protected]>

Enable tests

974dea8

Signed-off-by: Nana Essilfie-Conduah <[email protected]>

wip: enable and refactor token management tests

e78fbd7

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov added 5 commits September 13, 2022 11:53

test: hts precompile updateTokenKeys

dc34cf5

Signed-off-by: Ivo Yankov <[email protected]>

fix: trying to fix failing tests

86b2314

Signed-off-by: Ivo Yankov <[email protected]>

nit: reduce hbar usage

6a9a5c6

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 409-hts-precompile-token-key-tests

09d905f

# Conflicts: # packages/server/tests/contracts/BaseHTS.json

resolve conflicts

cd5fefe

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov marked this pull request as ready for review September 14, 2022 15:00

Nana-EC previously approved these changes Sep 14, 2022

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

tools/hardhat-example/hardhat.config.js Outdated Show resolved Hide resolved

Ivo-Yankov dismissed Nana-EC’s stale review via 018d077 September 15, 2022 06:45

chore: revert accidental changes

35b8a1f

Signed-off-by: Ivo Yankov <[email protected]>

natanasow previously approved these changes Sep 15, 2022

View reviewed changes

Ivo-Yankov added 2 commits September 16, 2022 12:37

chore: resolve conflicts

86fa2e8

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov dismissed natanasow’s stale review via 86fa2e8 September 16, 2022 09:42

Nana-EC previously approved these changes Sep 16, 2022

View reviewed changes

Ivo-Yankov added 2 commits September 18, 2022 20:53

chore: resolve conflicts

76c93f3

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov dismissed Nana-EC’s stale review via 76c93f3 September 18, 2022 18:33

georgi-l95 previously approved these changes Sep 18, 2022

View reviewed changes

test: enable pending tests

b82733b

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov dismissed georgi-l95’s stale review via b82733b September 19, 2022 07:32

Ivo-Yankov added 3 commits September 19, 2022 15:57

test: create a new hts precompile test suite

4cee6b4

Signed-off-by: Ivo Yankov <[email protected]>

test: remove duplicated tests

4dc9abe

Signed-off-by: Ivo Yankov <[email protected]>

fix: add npm script for new test suite

f57f0b8

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov mentioned this pull request Sep 19, 2022

Enable pending acceptance tests #524

Closed

2 tasks

lukelee-sl reviewed Sep 19, 2022

View reviewed changes

Nana-EC requested changes Sep 20, 2022

View reviewed changes

.github/workflows/acceptance.yml Outdated Show resolved Hide resolved

packages/server/tests/contracts/contracts_v2/BaseHTS.sol Outdated Show resolved Hide resolved

Ivo-Yankov added 3 commits September 20, 2022 13:06

chore: refactor hts precompile test structure

fcb283e

Signed-off-by: Ivo Yankov <[email protected]>

fix: CI acceptance filters

90cb10f

Signed-off-by: Ivo Yankov <[email protected]>

nit: test titles

a937d19

Signed-off-by: Ivo Yankov <[email protected]>

Nana-EC requested changes Sep 20, 2022

View reviewed changes

packages/server/tests/contracts/TokenManagementContract.sol Outdated Show resolved Hide resolved

chore: rearrange functions in contracts

3e5cbef

Signed-off-by: Ivo Yankov <[email protected]>

Nana-EC approved these changes Sep 20, 2022

View reviewed changes

Nana-EC reviewed Sep 20, 2022

View reviewed changes

Nana-EC merged commit abab2db into main Sep 20, 2022

Nana-EC deleted the 409-hts-precompile-token-key-tests branch September 20, 2022 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTS precompile token key management tests #464

HTS precompile token key management tests #464

Ivo-Yankov commented Aug 23, 2022 •

edited by Nana-EC

Loading

codecov-commenter commented Sep 12, 2022 •

edited

Loading

Nana-EC left a comment

Nana-EC left a comment

Ivo-Yankov commented Sep 19, 2022

lukelee-sl Sep 19, 2022

Nana-EC left a comment

Nana-EC left a comment

sonarqubecloud bot commented Sep 20, 2022

Nana-EC left a comment

Nana-EC Sep 20, 2022


		import "./TokenCreate.sol";

		contract TokenContractContract is TokenCreate {

	contract TokenContractContract is TokenCreate {
	contract TokenCreateContract is TokenCreate {

HTS precompile token key management tests #464

HTS precompile token key management tests #464

Conversation

Ivo-Yankov commented Aug 23, 2022 • edited by Nana-EC Loading

codecov-commenter commented Sep 12, 2022 • edited Loading

Codecov Report

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Ivo-Yankov commented Sep 19, 2022

lukelee-sl Sep 19, 2022

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 20, 2022

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC Sep 20, 2022

Choose a reason for hiding this comment

Ivo-Yankov commented Aug 23, 2022 •

edited by Nana-EC

Loading

codecov-commenter commented Sep 12, 2022 •

edited

Loading