update acceptance tests to use new signatures. Create new acceptance… #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test to exercise old create token function signatures Signed-off-by: lukelee-sl <[email protected]>
Codecov ReportBase: 76.38% // Head: 76.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 12 12
Lines 923 923
Branches 144 144
=======================================
Hits 705 705
Misses 165 165
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Nana-EC
added
enhancement
Nana-EC
requested changes
Sep 13, 2022
Signed-off-by: lukelee-sl <[email protected]>
Nana-EC
requested changes
Sep 13, 2022
| }); | ||
| const txReceipt = await tx.wait(); | ||
| const { tokenAddress } = txReceipt.events.filter(e => e.event === 'CreatedToken')[0].args; | ||
|
|
||
| return tokenAddress; | ||
| } | ||
|
|
||
| it('should deploy baseHTSContract', async function () { |
There was a problem hiding this comment.
I guess what i meant was you could create the the token, instantiate the contract from the address and associate in one test for the 3 scenarios.
Basically
should createHTSToken&should associate to a tokenwould mergeshould createNftHTSToken&should associate to a nftwould mergeshould createHTSTokenWithCustomFees&should associate to a token with custom feeswould merge
should finsh setting up contracts shouldn't really be a thing.
The first parts can go into the tests where the Address is used and the wallet creations would be in the beforeAll
Just trying to make things contained but also ensure that it doesn't matter in what order tests are run
Signed-off-by: lukelee-sl <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
dimitrovmaksim
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#510) * update acceptance tests to use new signatures. Create new acceptance test to exercise old create token function signatures Signed-off-by: lukelee-sl <[email protected]> * increase fees for account Signed-off-by: lukelee-sl <[email protected]> * update description of HTS Precompile V1 test Signed-off-by: lukelee-sl <[email protected]> * adjust fees Signed-off-by: lukelee-sl <[email protected]> * increase fee for v1 acceptance tests Signed-off-by: lukelee-sl <[email protected]> * increase fee for v1 acceptance tests once more Signed-off-by: lukelee-sl <[email protected]> * address review comments Signed-off-by: lukelee-sl <[email protected]> * refactor tests Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: Maksim Dimitrov <[email protected]>
dimitrovmaksim
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#510) * update acceptance tests to use new signatures. Create new acceptance test to exercise old create token function signatures Signed-off-by: lukelee-sl <[email protected]> * increase fees for account Signed-off-by: lukelee-sl <[email protected]> * update description of HTS Precompile V1 test Signed-off-by: lukelee-sl <[email protected]> * adjust fees Signed-off-by: lukelee-sl <[email protected]> * increase fee for v1 acceptance tests Signed-off-by: lukelee-sl <[email protected]> * increase fee for v1 acceptance tests once more Signed-off-by: lukelee-sl <[email protected]> * address review comments Signed-off-by: lukelee-sl <[email protected]> * refactor tests Signed-off-by: lukelee-sl <[email protected]> Signed-off-by: lukelee-sl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test to exercise old create token function signatures
Signed-off-by: lukelee-sl [email protected]
Description:
The following pull requests updated the type signatures for functions and structures to better match protobuf and documentation.
hashgraph/hedera-smart-contracts#59
hashgraph/hedera-services#3910
Modify the solidity files to reflect the changes in the smart contracts repo.
Ensure that the acceptance tests run as expected with the new type signatures.
Create a new acceptance test to ensure that the old signature also work as expected.
Related issue(s):
Fixes #509
Notes for reviewer:
Checklist