Add exponential backoff to axios retry #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm not exactly sure what the chart means but seem like we are waiting more with each iteration and thus the total time increases exponentially. |
lukelee-sl
approved these changes
Feb 22, 2023
Nana-EC
approved these changes
Feb 23, 2023
|
@lukelee-sl Yeah, sorry, I should've explained the charts better, those are E2E test runs before this change and after. As we are aiming to make local node development faster, this is a step in that direction. |
georgi-l95
deleted the
689-introduce-exponential-backoff-for-axios-retry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds exponential backoff to axios retry and change configurable retry time to the most efficient.
With this change, we'll have most of the optimisations merged. From here onwards we'll have to look for optimisations to other components (mirror-node, network-node).
Related issue(s):
Fixes #689
Notes for reviewer:
Checklist