Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yq install in deploy branch #8751

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix yq install in deploy branch #8751

merged 1 commit into from
Jul 10, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Another attempt at fixing yq install in deploy branch.

Related issue(s):

Notes for reviewer:

Functioning workflow though somehow when ran via repository_dispatch it differs somehow: https://github.com/hashgraph/hedera-mirror-node/actions/runs/9881129350

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added bug Type: Something isn't working process Build or test related tasks github_actions Pull requests that update GitHub Actions code labels Jul 10, 2024
@steven-sheehy steven-sheehy added this to the 0.110.0 milestone Jul 10, 2024
@steven-sheehy steven-sheehy requested a review from a team July 10, 2024 20:52
@steven-sheehy steven-sheehy self-assigned this Jul 10, 2024
@steven-sheehy steven-sheehy requested review from xin-hedera and a team and removed request for a team July 10, 2024 20:52
Copy link

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (8757b5d) to head (d51e3ac).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8751      +/-   ##
============================================
- Coverage     92.61%   92.18%   -0.44%     
- Complexity     5116     7546    +2430     
============================================
  Files           688      924     +236     
  Lines         22096    30270    +8174     
  Branches       2759     3664     +905     
============================================
+ Hits          20464    27903    +7439     
- Misses         1050     1544     +494     
- Partials        582      823     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 106ed39 into main Jul 10, 2024
29 checks passed
@steven-sheehy steven-sheehy deleted the yq-deploy branch July 10, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working github_actions Pull requests that update GitHub Actions code process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants