Use owner in backfill ethereum transaction hash migration #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
xin-hedera
commented
Aug 20, 2024
...main/java/com/hedera/mirror/importer/migration/BackfillEthereumTransactionHashMigration.java
Show resolved
Hide resolved
|
mgoelswirlds
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9080 +/- ##
=========================================
Coverage 92.20% 92.20%
- Complexity 7706 7708 +2
=========================================
Files 933 933
Lines 30771 30777 +6
Branches 3750 3750
=========================================
+ Hits 28371 28377 +6
Misses 1562 1562
Partials 838 838 ☔ View full report in Codecov by Sentry. |
steven-sheehy
approved these changes
Aug 20, 2024
xin-hedera
deleted the
9079-backfillethereumtransactionhashmigration-failed-due-to-db-role-permission
branch
xin-hedera
added a commit
that referenced
this pull request
Aug 20, 2024
- Use owner mirror_node in the migration Signed-off-by: Xin Li <[email protected]>
jascks
pushed a commit
that referenced
this pull request
Aug 22, 2024
- Use owner mirror_node in the migration Signed-off-by: Xin Li <[email protected]> Signed-off-by: Jeff Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the delete permission issue
Related issue(s):
Fixes #9079
Notes for reviewer:
Checklist