Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust citus resources #9228

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

xin-hedera
Copy link
Collaborator

@xin-hedera xin-hedera commented Sep 2, 2024

Description:

Related issue(s):

Fixes #9203

Notes for reviewer:

Require changing worker node-pool instance type to at least n2-custom-12-40960 (12 CPUs, 40GB memory) prior to deploy the changes.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera linked an issue Sep 2, 2024 that may be closed by this pull request
@xin-hedera xin-hedera self-assigned this Sep 2, 2024
@xin-hedera xin-hedera added enhancement Type: New feature database Area: Database citus Area: Citus labels Sep 2, 2024
@xin-hedera xin-hedera added this to the 0.113.0 milestone Sep 2, 2024
jascks
jascks previously approved these changes Sep 2, 2024
Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (7a95159) to head (c7b9e55).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9228   +/-   ##
=========================================
  Coverage     92.53%   92.53%           
  Complexity     6997     6997           
=========================================
  Files           902      902           
  Lines         29562    29562           
  Branches       3731     3731           
=========================================
  Hits          27356    27356           
  Misses         1442     1442           
  Partials        764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update docs/database/README.md. Both the setup section and the Database migration from V1 to V2 section. Maybe we can even mention if using GKE the specific machine type.

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera marked this pull request as ready for review September 3, 2024 17:23
Copy link
Member

@mgoelswirlds mgoelswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xin-hedera xin-hedera merged commit e653779 into main Sep 3, 2024
37 checks passed
@xin-hedera xin-hedera deleted the 9203-increase-resources-to-database-node-pools branch September 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
citus Area: Citus database Area: Database enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase resources to database node pools
5 participants