-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust citus resources #9228
Adjust citus resources #9228
Conversation
Signed-off-by: Xin Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9228 +/- ##
=========================================
Coverage 92.53% 92.53%
Complexity 6997 6997
=========================================
Files 902 902
Lines 29562 29562
Branches 3731 3731
=========================================
Hits 27356 27356
Misses 1442 1442
Partials 764 764 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update docs/database/README.md. Both the setup section and the Database migration from V1 to V2
section. Maybe we can even mention if using GKE the specific machine type.
Signed-off-by: Xin Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description:
Related issue(s):
Fixes #9203
Notes for reviewer:
Require changing worker node-pool instance type to at least n2-custom-12-40960 (12 CPUs, 40GB memory) prior to deploy the changes.
Checklist