Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access List is not supported in signature calculation #17040

Open
se7enarianelabs opened this issue Dec 12, 2024 · 1 comment · May be fixed by #17268
Open

Access List is not supported in signature calculation #17040

se7enarianelabs opened this issue Dec 12, 2024 · 1 comment · May be fixed by #17268
Assignees
@arianejasuwienas
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Milestone
v0.59

Comments

@se7enarianelabs
Copy link

Description

Access List is not supported in signature calculation.

Steps to reproduce

  1. Create an Ethereum transaction with an access list.
  2. Verify the signature calculation

Additional context

No response

Hedera network

mainnet, testnet, previewnet, other

Version

v0.1.0

Operating system

None
mmyslariane added a commit to mmyslariane/hedera-services that referenced this issue Dec 12, 2024
@mmyslariane
hashgraph#17040 included access list as RLPList in calculating signat…
18da12d 
…ure in EthTxSigs by passing it as array of object and encoding it as list in RLPEncoder
@mmyslariane mmyslariane mentioned this issue Dec 12, 2024
Open
2 tasks
@poulok
Copy link
Member

poulok commented Dec 16, 2024

@se7enarianelabs please be sure to add tickets to the appropriate project in GitHub.

mmyslariane added a commit to mmyslariane/hedera-services that referenced this issue Dec 16, 2024
@mmyslariane
hashgraph#17040 changed accessListAsRlp from RLPList type to Object[]
f928476
mmyslariane added a commit to mmyslariane/hedera-services that referenced this issue Dec 20, 2024
@mmyslariane
hashgraph#17040 declared ethTx field as final
0f06c2c
mmyslariane added a commit to mmyslariane/hedera-services that referenced this issue Jan 7, 2025
@mmyslariane
hashgraph#17040 comment on check for 0 address
f74a3a7
mmyslariane added a commit to mmyslariane/hedera-services that referenced this issue Jan 8, 2025
@mmyslariane
hashgraph#17040 revert on EtheruemTransactionHandler
dcdc301
@arianejasuwienas arianejasuwienas linked a pull request Jan 8, 2025 that will close this issue
Draft
2 tasks
@arianejasuwienas arianejasuwienas moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Jan 8, 2025
@arianejasuwienas arianejasuwienas linked a pull request Jan 8, 2025 that will close this issue
feat: access list support for signature calculation #17268
Draft
2 tasks
@mmyslariane mmyslariane mentioned this issue Jan 15, 2025
Closed
2 tasks
@arianejasuwienas arianejasuwienas mentioned this issue Jan 15, 2025
Open
2 tasks
arianejasuwienas added a commit that referenced this issue Jan 15, 2025
@arianejasuwienas
fix: update copyright year to 2025 for files modified in 2025 (#17040)
6e440ac 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 20, 2025
@arianejasuwienas
feat: describing tx type differences, considering access list rlp in …
7d05ee4 
…equals method, adding new tests for the access list rlp (#17040)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas added a commit that referenced this issue Jan 21, 2025
@arianejasuwienas
feat: preventing merge conflicts by including changes from main branch (
4964f27 
#17040)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas arianejasuwienas self-assigned this Jan 23, 2025
@arianejasuwienas arianejasuwienas moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Jan 23, 2025
@arianejasuwienas arianejasuwienas added this to the v0.59 milestone Jan 23, 2025
@arianejasuwienas arianejasuwienas added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arianejasuwienas arianejasuwienas

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Smart Contract Sprint Board
Status: In Review
Milestone
v0.59
Development

Successfully merging a pull request may close this issue.

feat: access list support for signature calculation hashgraph/hedera-services
3 participants
@poulok @arianejasuwienas @se7enarianelabs