Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error msg upon updating custom fees for fungible or non fungible tokens if list is more than 10 #17533

Closed
15 tasks
nadezhdapopovaa opened this issue Jan 24, 2025 · 0 comments · Fixed by #17703
Assignees
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.

Comments

@nadezhdapopovaa
Copy link

nadezhdapopovaa commented Jan 24, 2025

Background

In smart-contracts we want to bump the version of the local node from 2.32.6 to 2.33.0 which updates the version of the services from 0.54.0-alpha.5 to 0.57.3. The problem is that in smart contracts there are two tests which check error msg upon trying to update custom fees for list of fungible or non fungible tokens which is more than 10. The expected error is CUSTOM_FEES_LIST_TOO_LONG, but the error received is INVALID_OPERATION.

Note: version 0.54.2 works okay with the tests and then from version 0.55.0 the tests start failing.

Blocks: 1207 from smart contracts

Acceptance Criteria

Expected msg CUSTOM_FEES_LIST_TOO_LONG

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
2 participants