-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add HandleException
catch block to return correct error responses in SystemContracts
#17703
fix: Add HandleException
catch block to return correct error responses in SystemContracts
#17703
Conversation
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17703 +/- ##
============================================
+ Coverage 68.91% 68.94% +0.02%
- Complexity 22999 23014 +15
============================================
Files 2647 2647
Lines 99516 99537 +21
Branches 10298 10302 +4
============================================
+ Hits 68585 68625 +40
+ Misses 27033 27022 -11
+ Partials 3898 3890 -8
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(If you agree with my comment about a separate API then create an issue for it?)
...main/java/com/hedera/services/bdd/suites/contract/precompile/UpdateTokenFeeScheduleTest.java
Show resolved
Hide resolved
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though a big reservation about how complex the code in AbstractNativeSystemContract.computeFully
has gotten over time. But I filed a separate issue to address that.
Description:
This PR adds a catch block to return the correct response for the fail-fast validations in the SystemContracts.
Update BDD tests to verify responses.
Related issue(s):
Fixes #17533
Fixes #17534
Notes for reviewer:
Checklist