Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cherry-Pick (0.56): Update TokensConfig countingGetBalanceThrottleEnabled default to true #16366

Merged

Conversation

derektriley
Copy link
Contributor

@derektriley derektriley commented Oct 31, 2024

Description:

This pull request includes a change to the TokensConfig class in the hedera-node project to modify the default value of the countingGetBalanceThrottleEnabled property.

Related PR to develop: #16363

Related issue(s):

Fixes #16361

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@derektriley derektriley added this to the v0.56 milestone Oct 31, 2024
@derektriley derektriley self-assigned this Oct 31, 2024
@derektriley derektriley requested a review from a team as a code owner October 31, 2024 21:05
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8978fa6) 99989 61887 61.89%
Head commit (9bea311) 99989 (+0) 61887 (+0) 61.89% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16366) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.56@8978fa6). Learn more about missing BASE report.
Report is 4 commits behind head on release/0.56.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.56   #16366   +/-   ##
===============================================
  Coverage                ?   58.29%           
  Complexity              ?    19925           
===============================================
  Files                   ?     2731           
  Lines                   ?   100172           
  Branches                ?    10351           
===============================================
  Hits                    ?    58400           
  Misses                  ?    38148           
  Partials                ?     3624           
Files with missing lines Coverage Δ
...java/com/hedera/node/config/data/TokensConfig.java 100.00% <ø> (ø)

Impacted file tree graph

@povolev15 povolev15 merged commit f8e9628 into release/0.56 Nov 1, 2024
65 of 66 checks passed
@povolev15 povolev15 deleted the 16361-countingGetBalanceThrottleEnabled-cherry-pick branch November 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants