Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Roll hiero gradle conventions to version 0.1.4 #17149

Merged

Conversation

andrewb1269hg
Copy link
Contributor

@andrewb1269hg andrewb1269hg commented Dec 20, 2024

Description:

Roll the hiero gradle build to version 0.1.4 to resolve publishing issue.

Related Issue(s):

Fixes #17148

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

**Description**:

Roll the hiero gradle conventions to version 1.3.0 to resolve publishing issue.

**Related Issue(s)**:

Fixes #17148

Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg andrewb1269hg requested review from a team as code owners December 20, 2024 18:01
@andrewb1269hg andrewb1269hg linked an issue Dec 20, 2024 that may be closed by this pull request
@andrewb1269hg
Copy link
Contributor Author

andrewb1269hg commented Dec 20, 2024

I presented this issue to @jjohannes who identified and resolved the fix in hiero-ledger/hiero-gradle-conventions repo. I am rolling the version number forward in hedera-services to resolve the publishing issue.

Here's a link to the resolution commit

@andrewb1269hg andrewb1269hg added this to the v0.58 milestone Dec 20, 2024
@andrewb1269hg andrewb1269hg self-assigned this Dec 20, 2024
@andrewb1269hg andrewb1269hg added the github_actions Pull requests that update GitHub Actions code label Dec 20, 2024
@andrewb1269hg andrewb1269hg changed the title build: Roll hiero gradle conventions to version 1.3.0 build: Roll hiero gradle conventions to version 0.1.3 Dec 20, 2024
rbarker-dev
rbarker-dev previously approved these changes Dec 20, 2024
Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aee0358) 95748 65121 68.01%
Head commit (3cd2448) 95748 (+0) 65135 (+14) 68.03% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17149) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (aee0358) to head (3cd2448).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17149      +/-   ##
=============================================
+ Coverage      64.26%   64.27%   +0.01%     
- Complexity     20882    20888       +6     
=============================================
  Files           2549     2549              
  Lines          95985    95985              
  Branches       10044    10044              
=============================================
+ Hits           61683    61696      +13     
+ Misses         30673    30659      -14     
- Partials        3629     3630       +1     

see 11 files with indirect coverage changes

Impacted file tree graph

@andrewb1269hg andrewb1269hg changed the title build: Roll hiero gradle conventions to version 0.1.3 build: Roll hiero gradle conventions to version 0.1.4 Dec 20, 2024
Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg
Copy link
Contributor Author

Rolled version forward to 0.1.4 to correct for releasePrereleaseChannel fix.

@andrewb1269hg andrewb1269hg merged commit 1e4a206 into develop Dec 21, 2024
46 checks passed
@andrewb1269hg andrewb1269hg deleted the 17148-fix-publishing-issue-with-gradle-conventions branch December 21, 2024 01:44
andrewb1269hg added a commit that referenced this pull request Dec 21, 2024
Nana-EC pushed a commit that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Publishing Issue with Gradle Conventions
2 participants