Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support universal fallback for throttles.json genesis loading #17181

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

nathanklick
Copy link
Member

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @nathanklick !

@nathanklick nathanklick added this to the v0.58 milestone Dec 30, 2024
@nathanklick nathanklick added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Dec 30, 2024
@nathanklick nathanklick self-assigned this Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (32645d1) to head (deab4c1).
Report is 1 commits behind head on release/0.58.

Files with missing lines Patch % Lines
...app/service/file/impl/schemas/V0490FileSchema.java 27.27% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.58   #17181      +/-   ##
==================================================
- Coverage           64.33%   64.32%   -0.01%     
+ Complexity          20910    20909       -1     
==================================================
  Files                2549     2549              
  Lines               95991    95999       +8     
  Branches            10045    10046       +1     
==================================================
  Hits                61756    61756              
- Misses              30602    30608       +6     
- Partials             3633     3635       +2     
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/BootstrapConfig.java 100.00% <ø> (ø)
...app/service/file/impl/schemas/V0490FileSchema.java 88.80% <27.27%> (-1.67%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (32645d1) 95754 65197 68.09%
Head commit (deab4c1) 95762 (+8) 65199 (+2) 68.08% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17181) 11 4 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@netopyr netopyr merged commit 6f7583c into release/0.58 Jan 2, 2025
56 of 68 checks passed
@netopyr netopyr deleted the 17177-R58-Cherry-Pick branch January 2, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants