Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds example HRC904 contracts + airdrop test coverage + hrc904Proxy test coverage #1124

Closed

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Dec 20, 2024

Description:

This PR adds example contracts for HRC904 #1012 functionality such as cancelAirdrops, claimAirdrops, airdropTokens, rejectTokens as well as test coverage for airdropTokens

Related issue(s):

Fixes #1109

Notes for reviewer:
As of 20.12 this PR is incomplete, I have added the additional items in the checklist below that need to be done:

Checklist

  • Figure out a way to make assertions on the child transaction (my biggest issue currently)
  • Fix failing tests where the balance is not correct possibly due to race condition
  • Polish code, export util functions, remove redundancy in code, etc.
  • Add the correct response codes and message in the assertions

@simzzz simzzz closed this Dec 20, 2024
@simzzz simzzz changed the title feat: example contracts + airdrop test coverage feat: adds example HRC904 contracts + airdrop test coverage + hrc904Proxy test coverage Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests that verify IHRC904 airdropToken targeted to an EOA are functional when called by a contract
1 participant