feat: added test coverage of CancelAirdrop.sol #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <[email protected]>
simzzz
requested review from
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
konstantinabl
requested changes
Jan 28, 2025
test/system-contracts/hedera-token-service/hrc-904/CancelAirdropContract.js
Outdated
Show resolved
Hide resolved
quiet-node
requested changes
Jan 29, 2025
test/system-contracts/hedera-token-service/hrc-904/CancelAirdropContract.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/CancelAirdropContract.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/CancelAirdropContract.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/CancelAirdropContract.js
Outdated
Show resolved
Hide resolved
quiet-node
previously approved these changes
Jan 30, 2025
konstantinabl
previously approved these changes
Feb 4, 2025
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
simzzz
force-pushed
the
1189-cancel-airdrop-coverage
branch
from
4dc5c46 to
04b8ede
Compare
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
simzzz
force-pushed
the
1189-cancel-airdrop-coverage
branch
from
04b8ede to
1f9923a
Compare
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
quiet-node
approved these changes
Feb 4, 2025
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
* feat: added test coverage of CancelAirdrop.sol Signed-off-by: Simeon Nakov <[email protected]> * feat: changes test suite string Signed-off-by: Simeon Nakov <[email protected]> * feat: changed code comment Signed-off-by: Simeon Nakov <[email protected]> * skipped tests temporarily Signed-off-by: Simeon Nakov <[email protected]> * feat: added test coverage of CancelAirdrop.sol Signed-off-by: Simeon Nakov <[email protected]> * revert removal of deploy functions Signed-off-by: Simeon Nakov <[email protected]> * exported magic string as constant Signed-off-by: Simeon Nakov <[email protected]> * more clear comments for skipped tests Signed-off-by: Simeon Nakov <[email protected]> * requested changes from review Signed-off-by: Simeon Nakov <[email protected]> * fix conflicts Signed-off-by: Simeon Nakov <[email protected]> --------- Signed-off-by: Simeon Nakov <[email protected]>
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
* feat: added test coverage of CancelAirdrop.sol Signed-off-by: Simeon Nakov <[email protected]> * feat: changes test suite string Signed-off-by: Simeon Nakov <[email protected]> * feat: changed code comment Signed-off-by: Simeon Nakov <[email protected]> * skipped tests temporarily Signed-off-by: Simeon Nakov <[email protected]> * feat: added test coverage of CancelAirdrop.sol Signed-off-by: Simeon Nakov <[email protected]> * revert removal of deploy functions Signed-off-by: Simeon Nakov <[email protected]> * exported magic string as constant Signed-off-by: Simeon Nakov <[email protected]> * more clear comments for skipped tests Signed-off-by: Simeon Nakov <[email protected]> * requested changes from review Signed-off-by: Simeon Nakov <[email protected]> * fix conflicts Signed-off-by: Simeon Nakov <[email protected]> --------- Signed-off-by: Simeon Nakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added tests that verify IHRC904 cancelAirdrops targeted to an EOA are functional when called by a contract
Related issue(s):
Closes #1189
Notes for reviewer:
Checklist