Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in verification after importing the contract into Remix #65

Closed
Neurone opened this issue Nov 2, 2023 · 2 comments
Closed

Error in verification after importing the contract into Remix #65

Neurone opened this issue Nov 2, 2023 · 2 comments
Assignees
Labels
bug A error that causes the feature to behave differently than what was expected based on design docs

Comments

@Neurone
Copy link

Neurone commented Nov 2, 2023

Description

Importing the contract inside Remix, I see Hedera in the list of networks, but the call is still to sourcify.dev, so it returns an error.

Steps to reproduce

  1. verify a contract
  2. check contract details (i.e., https://repository-verify.hashscan.io/contracts/full_match/295/0x00000000000000000000000000000000003Be792/)
  3. click "open repo in Remix"
  4. try the verification with the Hedera network

Additional context

Screenshot from 2023-10-27 15-57-39

Hedera network

mainnet, testnet, previewnet, other

Version

N/A

Operating system

None

@Neurone Neurone added the bug A error that causes the feature to behave differently than what was expected based on design docs label Nov 2, 2023
@svienot
Copy link
Contributor

svienot commented Nov 3, 2023

I am not sure at this point how feasible it is to have the remix-sourcify plugin talk to our instance in addition to the sourcify.dev instance. An alternative might be to produce our own fork of that plugin to have Remix interfaced with our instance. We need to look into that further.
Meanwhile we are going to remove these "open in Remix" links. Already done in the main Sourcify ui, remains to be done for this select-form of the repository service.

@svienot svienot self-assigned this Nov 3, 2023
svienot added a commit that referenced this issue Nov 7, 2023
Fix initialization bug in select-contract-form (issue #64)

Signed-off-by: Simon Viénot <[email protected]>
@svienot svienot mentioned this issue Nov 7, 2023
svienot added a commit that referenced this issue Nov 7, 2023
Fix initialization bug in select-contract-form (issue #64)

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Copy link
Contributor

svienot commented Nov 7, 2023

The "open repo in remix" has been wiped from both main ui and repository ui. So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

No branches or pull requests

2 participants