chore: add server tests for dryrun query parameter #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svienot
requested review from
quiet-node,
Sheng-Long,
acuarica,
a team,
ericleponner and
Nana-EC
and removed request for
a team,
quiet-node and
Sheng-Long
acuarica
approved these changes
Dec 19, 2023
acuarica
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Is it possible that these tests are not idempotent? I'm running the test multiple times, and it fails the second time.
1) Server
session api verification
should not store the successful verification result when the query parameter dryrun=true is provided:
Contract should not have been saved
acuarica
reviewed
Dec 19, 2023
|
@acuarica I do not see this issue when running the test several times (I do that interactively within IntelliJ). |
…rtions.js. Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
Signed-off-by: Simon Viénot <[email protected]>
…clause. Signed-off-by: Simon Viénot <[email protected]>
svienot
force-pushed
the
93-test-dry-run-query-parameter
branch
from
643d5b8 to
2c3606b
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add tests for the
dryrunquery parameter recently added to the/session/input-filesand/session/verify-checkedAPI endpoints.Related issue(s):
Fixes #93