Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart updates #23

Closed
wants to merge 4 commits into from
Closed

Helm chart updates #23

wants to merge 4 commits into from

Conversation

rustyShacklefurd
Copy link
Contributor

@rustyShacklefurd rustyShacklefurd commented Aug 18, 2023

Description:
Working through the helm deployments and default values.

2023-10-04 - this PR currently represents the working version of the initial deployment

…now its one pull secret for all but deploys; might be better to attach these per service account for the component being deployed

Signed-off-by: Matt Halder <[email protected]>
… routing between the three components

Signed-off-by: Matt Halder <[email protected]>
@rustyShacklefurd rustyShacklefurd marked this pull request as ready for review October 4, 2023 17:50
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Seems like liveness and readiness probes will see follow up improvements

REPOSITORY_PATH: {{ template "sourcify.fullname" . }}-repository # Repository service name in the same namespace
SERVER_PORT: {{ .Values.server.service.port }}
SERVER_URL: {{ .Values.repository.config.url }}
{{- end }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add new line for git happiness

@rustyShacklefurd
Copy link
Contributor Author

This PR is superseded by PR #26

@acuarica acuarica deleted the helm-chart-updates branch June 3, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants