Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update h5ai-nginx patch to pin the h5ai revision #96

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

svienot
Copy link
Contributor

@svienot svienot commented Dec 11, 2023

Update h5ai-nginx patch such that the Dockerfile checks out a specific commit in h5ai repository before applying the h5ai patch.

Related issue(s):

Fixes #83

@svienot svienot requested review from acuarica and Nana-EC December 11, 2023 16:25
@svienot svienot self-assigned this Dec 11, 2023
@svienot svienot marked this pull request as ready for review December 11, 2023 16:26
@svienot svienot requested review from a team as code owners December 11, 2023 16:26
@svienot svienot requested review from Sheng-Long and removed request for a team and Sheng-Long December 11, 2023 16:26
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hedera-patch/h5ai-nginx.patch Outdated Show resolved Hide resolved
@svienot svienot force-pushed the 0083-pin-h5ai-revision branch from b24e830 to 48eb144 Compare December 11, 2023 22:21
…of h5ai before applying patch.

Signed-off-by: Simon Viénot <[email protected]>
@svienot svienot force-pushed the 0083-pin-h5ai-revision branch from 48eb144 to 02b13db Compare December 11, 2023 22:25
@svienot svienot merged commit b2b0e7f into main Dec 11, 2023
5 checks passed
@svienot svienot deleted the 0083-pin-h5ai-revision branch December 11, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin the h5ai revision
3 participants