Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information regarding Ed25519 & ECDSA Keys to docs #419

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

itsbrandondev
Copy link

This PR adds a new page to the WalletConnect documentation that explians the differences of Ed25519 & ECDSA keys, important for ETH developers who need full EVM compatibility.

It also modifies one page to move it down the sidebar.

This PR is informational and only adds to the documentation, it does not impact the library.

@itsbrandondev itsbrandondev requested review from a team as code owners January 20, 2025 20:00
@itsbrandondev itsbrandondev requested a review from mgarbs January 20, 2025 20:00
@itsbrandondev itsbrandondev self-assigned this Jan 20, 2025
@itsbrandondev itsbrandondev added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.65% 523/665
🟡 Branches 64.34% 92/143
🟡 Functions 77.63% 118/152
🟡 Lines 79.94% 494/618

Test suite run success

153 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from dd19b5c

kantorcodes
kantorcodes previously approved these changes Jan 21, 2025
Copy link
Contributor

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good summary, though added 1 comment that should be addressed.

docs/docs/ed25519-ecdsa-keys.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants