Skip to content

Commit

Permalink
Avoid failing on windows due to different separator
Browse files Browse the repository at this point in the history
Signed-off-by: Jeffrey Tang <[email protected]>
  • Loading branch information
JeffreyDallas committed Dec 12, 2024
1 parent 1780ad5 commit 300a600
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/commands/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {type Opts} from '../types/command_types.js';
import {type CommandFlag} from '../types/flag_types.js';
import {type Lease} from '../core/lease/lease.js';
import {Listr} from 'listr2';
import path from 'path';

export interface CommandHandlers {
parent: BaseCommand;
Expand Down Expand Up @@ -74,7 +75,7 @@ export abstract class BaseCommand extends ShellRunner {
if (!chartReleaseName) throw new MissingArgumentError('chart release name is required');

if (chartDir) {
const chartPath = `${chartDir}/${chartReleaseName}`;
const chartPath = path.join(chartDir, chartReleaseName);

Check warning on line 78 in src/commands/base.ts

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/commands/base.ts#L78

Detected possible user input going into a `path.join` or `path.resolve` function.
await this.helm.dependency('update', chartPath);
return chartPath;
}
Expand Down

0 comments on commit 300a600

Please sign in to comment.