refactored to extract methods for TODO

Signed-off-by: Jeromy Cannon <[email protected]>
hashgraph · Jan 7, 2025 · 754ac73 · 754ac73
1 parent 214fe28
commit 754ac73
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 11 deletions.
diff --git a/src/commands/node/tasks.ts b/src/commands/node/tasks.ts
@@ -872,19 +872,13 @@ export class NodeCommandTasks {
 
   setupNetworkNodes(nodeAliasesProperty: string) {
     return new Task('Setup network nodes', async (ctx: any, task: ListrTaskWrapper<any, any, any>) => {
-      // TODO extract method
-      const networkNodeServiceMap = await this.accountManager.getNodeServiceMap(ctx.config.namespace);
-
-      const genesisNetworkData = await GenesisNetworkDataConstructor.initialize(
+      await this.generateGenesisNetworkJson(
+        ctx.config.namespace,
         ctx.config.nodeAliases,
-        this.keyManager,
         ctx.config.keysDir,
-        networkNodeServiceMap,
+        ctx.config.stagingDir,
       );
 
-      const genesisNetworkJson = path.join(ctx.config.stagingDir, 'genesis-network.json');
-      fs.writeFileSync(genesisNetworkJson, genesisNetworkData.toJSON());
-
       const subTasks = [];
       for (const nodeAlias of ctx.config[nodeAliasesProperty]) {
         const podName = ctx.config.podNames[nodeAlias];
@@ -902,6 +896,33 @@ export class NodeCommandTasks {
     });
   }
 
+  /**
+   * Generate genesis network json file
+   * @private
+   * @param namespace - namespace
+   * @param nodeAliases - node aliases
+   * @param keysDir - keys directory
+   * @param stagingDir - staging directory
+   */
+  private async generateGenesisNetworkJson(
+    namespace: string,
+    nodeAliases: NodeAliases,
+    keysDir: string,
+    stagingDir: string,
+  ) {
+    const networkNodeServiceMap = await this.accountManager.getNodeServiceMap(namespace);
+
+    const genesisNetworkData = await GenesisNetworkDataConstructor.initialize(
+      nodeAliases,
+      this.keyManager,
+      keysDir,
+      networkNodeServiceMap,
+    );
+
+    const genesisNetworkJson = path.join(stagingDir, 'genesis-network.json');
+    fs.writeFileSync(genesisNetworkJson, genesisNetworkData.toJSON());
+  }
+
   prepareStagingDirectory(nodeAliasesProperty: any) {
     return new Task('Prepare staging directory', (ctx: any, task: ListrTaskWrapper<any, any, any>) => {
       const config = ctx.config;

diff --git a/src/core/platform_installer.ts b/src/core/platform_installer.ts
@@ -285,8 +285,7 @@ export class PlatformInstaller {
         {
           title: 'Copy configuration files',
           task: async () => {
-            const genesisNetworkJson = [path.join(stagingDir, 'genesis-network.json')];
-            await self.copyFiles(podName, genesisNetworkJson, `${constants.HEDERA_HAPI_PATH}/data/config`);
+            await this.copyConfigurationFiles(stagingDir, podName);
           },
         },
         {
@@ -303,6 +302,17 @@ export class PlatformInstaller {
     );
   }
 
+  /**
+   * Copy configuration files to the network consensus node pod
+   * @param stagingDir - staging directory path
+   * @param podName - network consensus node pod name
+   * @private
+   */
+  private async copyConfigurationFiles(stagingDir: string, podName: `network-node${number}-0`) {
+    const genesisNetworkJson = [path.join(stagingDir, 'genesis-network.json')];
+    await this.copyFiles(podName, genesisNetworkJson, `${constants.HEDERA_HAPI_PATH}/data/config`);
+  }
+
   /**
    * Return a list of task to copy the node keys to the staging directory
    *