Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Blockstreams and uploader #1109

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Jan 6, 2025

Description

Enables blockstreams and uploader:

  • Enables the consensus node sidecar
  • changes blockStream.streamMode to BOTH

Related Issues

… blockStream.streamMode=BOTH

Signed-off-by: instamenta <[email protected]>
@instamenta instamenta self-assigned this Jan 6, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners January 6, 2025 09:04
@instamenta instamenta linked an issue Jan 6, 2025 that may be closed by this pull request
…iness-enable-blockstreams-and-uploader

# Conflicts:
#	examples/solo-gke-test/application.properties
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   4s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fb89e5a. ± Comparison against base commit c27d1d6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   11s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fb89e5a. ± Comparison against base commit c27d1d6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 21m 13s ⏱️ + 1m 22s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a1c8d23. ± Comparison against base commit d8903a8.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 20m 48s ⏱️ - 2m 41s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fb89e5a. ± Comparison against base commit c27d1d6.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 6, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c27d1d6) 20606 17398 84.43%
Head commit (fb89e5a) 20634 (+28) 17425 (+27) 84.45% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1109) 10 10 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (c27d1d6) to head (fb89e5a).
Report is 38 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   83.67%   83.66%   -0.01%     
==========================================
  Files          77       77              
  Lines       20633    20634       +1     
  Branches     1788     1372     -416     
==========================================
- Hits        17264    17263       -1     
- Misses       3253     3316      +63     
+ Partials      116       55      -61     
Files with missing lines Coverage Δ
src/core/constants.ts 97.33% <100.00%> (+0.11%) ⬆️
src/core/profile_manager.ts 97.12% <100.00%> (-0.05%) ⬇️

... and 35 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to update the version file once we tag the solo-charts with the corresponding changes

@jeromy-cannon
Copy link
Contributor

Looks good, need to update the version file once we tag the solo-charts with the corresponding changes

@instamenta , Published solo-charts release 0.40.0

@jeromy-cannon jeromy-cannon merged commit ed6527b into main Jan 9, 2025
41 checks passed
@jeromy-cannon jeromy-cannon deleted the 01033-production-readiness-enable-blockstreams-and-uploader branch January 9, 2025 11:19
swirlds-automation added a commit that referenced this pull request Jan 13, 2025
## [0.33.0](v0.32.0...v0.33.0) (2025-01-13)

### Features

* add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8))
* enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b))
* inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c))
* production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41))
* support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e))
* update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6))
* Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894))
* use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806))

### Bug Fixes

* add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31))
* Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28))
* bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895))
* bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46))
* clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873))
* commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9))
* external link rendering ([#1118](#1118)) ([28af1fe](28af1fe))
* file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76))
* fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611))
* **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9))
* should run `npm install` before build ([#1117](#1117)) ([3398875](3398875))
* solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60))
* started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723))
* update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production Readiness: enable Blockstreams and uploader
3 participants