feat(remote-config): save reusable solo flags in remoteconfig #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r it Signed-off-by: instamenta <[email protected]>
…mote config common flags data wrapper and fix failing tests Signed-off-by: instamenta <[email protected]>
…re type imports because they are impossible to fix in the context of the remote config Signed-off-by: instamenta <[email protected]>
…olo-flags-in-remoteconfig
…olo-flags-in-remoteconfig # Conflicts: # src/core/config/remote/remote_config_manager.ts
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Jeromy Cannon <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
- Coverage 82.66% 82.63% -0.04%
==========================================
Files 77 78 +1
Lines 21440 21531 +91
Branches 1914 1856 -58
==========================================
+ Hits 17724 17792 +68
- Misses 3593 3602 +9
- Partials 123 137 +14
... and 6 files with indirect coverage changes |
…es when passed to command, since they are overriden on configManager.update which is called at the beggining of all commands Signed-off-by: instamenta <[email protected]>
…g the post middleware command execution Signed-off-by: instamenta <[email protected]>
instamenta
added
PR: Needs Approval
jeromy-cannon
added
the
PR: Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds new class
CommonFlagsDataWrapperto handle keeping the state of the flags inside the remote config, it's added to the middleware which loads and and it will populate the flags if needed.Related Issues