feat(cli): add new command solo deployment list that lists deployments on that specific cluster
#1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: instamenta <[email protected]>
…-list--cluster-solo-1---give-cluster-and-return-a-list-of-solo-deployments-on-that-cluster
…moteConfigPresentInNamespace Signed-off-by: instamenta <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 81.72% 81.67% -0.06%
==========================================
Files 79 79
Lines 20725 20750 +25
Branches 1931 1542 -389
==========================================
+ Hits 16937 16947 +10
- Misses 3622 3728 +106
+ Partials 166 75 -91
... and 29 files with indirect coverage changes |
jeromy-cannon
added
PR: Unresolved Comments
…-list--cluster-solo-1---give-cluster-and-return-a-list-of-solo-deployments-on-that-cluster # Conflicts: # src/commands/deployment.ts # src/core/kube/k8_client.ts
Signed-off-by: instamenta <[email protected]>
jeromy-cannon
removed
PR: Unresolved Comments
jeromy-cannon
approved these changes
Feb 3, 2025
jeromy-cannon
deleted the
00961-solo-deployment-list--cluster-solo-1---give-cluster-and-return-a-list-of-solo-deployments-on-that-cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new command
solo deployment list:command accepts
flag.clusterNameand gets context from the local config and lists all deployments/namespaces that have remote config inside them.Adds new method
K8.isRemoteConfigPresentInNamespace()to search for remote config inside a namespace.Related Issues