feat: handle multiple contexts during network deploy #1369

leninmehedy · 2025-02-12T06:36:42Z

Description

This pull request changes the following:

add support for multi-cluster values files
create secrets in multiple clusters
create namespace in multiple clusters as required
add a custom flag called networkDeploymentValuesFile to be used for solo network deployment command

Related Issues

Related Update solo network deploy --deployment to support multiple clusters #1357

Signed-off-by: Lenin Mehedy <[email protected]>

github-actions · 2025-02-12T06:38:33Z

Unit Test Results - Linux

1 files 56 suites 2s ⏱️
215 tests 211 ✅ 0 💤 4 ❌
225 runs 221 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 0d10e93.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-12T08:10:12Z

Unit Test Results - Windows

1 files 56 suites 3s ⏱️
215 tests 211 ✅ 0 💤 4 ❌
225 runs 221 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 0d10e93.

♻️ This comment has been updated with latest results.

src/commands/network.ts

Signed-off-by: Lenin Mehedy <[email protected]>

commit 5b3d68a Author: Lenin Mehedy <[email protected]> Date: Wed Feb 12 23:37:56 2025 +1100 feat: handle multiple contexts during network deploy (#1369) Signed-off-by: Lenin Mehedy <[email protected]> commit ea24bc4 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 00:19:23 2025 +0000 more todos Signed-off-by: Jeromy Cannon <[email protected]> commit 71388dd Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 00:10:26 2025 +0000 pushing latest Signed-off-by: Jeromy Cannon <[email protected]> commit 209c2cd Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:53:15 2025 +0000 updated cluster ref flag description Signed-off-by: Jeromy Cannon <[email protected]> commit 1a0a337 Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:52:12 2025 +0000 renamed flag clusterName to clusterRef Signed-off-by: Jeromy Cannon <[email protected]> commit f4087bf Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:41:02 2025 +0000 saving progress Signed-off-by: Jeromy Cannon <[email protected]> commit 537fc1a Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 20:51:03 2025 +0000 set the networks deploy config with the contexts and the consensus nodes for later use Signed-off-by: Jeromy Cannon <[email protected]> commit e86e94c Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 20:07:53 2025 +0000 added base test for getContexts Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

commit 40f5cc4 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 23:00:17 2025 +0000 added dns templating for fully qualified domain name Signed-off-by: Jeromy Cannon <[email protected]> commit 929fdaa Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 19:10:33 2025 +0000 got further into node add Signed-off-by: Jeromy Cannon <[email protected]> commit b9f6d10 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 17:24:29 2025 +0000 removed final todo for network deploy Signed-off-by: Jeromy Cannon <[email protected]> commit 03ad78f Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:55:15 2025 +0000 removed todo in addNodesAndProxies Signed-off-by: Jeromy Cannon <[email protected]> commit 54cc58f Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:42:13 2025 +0000 removed todo in title: 'Check auxiliary pods are ready' Signed-off-by: Jeromy Cannon <[email protected]> commit e060218 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:38:09 2025 +0000 removed todo in title: 'Check proxy pods are running', envoy proxy Signed-off-by: Jeromy Cannon <[email protected]> commit 9b43649 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:36:45 2025 +0000 removed todo in title: 'Check proxy pods are running' Signed-off-by: Jeromy Cannon <[email protected]> commit d08a239 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:28:25 2025 +0000 removed todo in title: 'Check node pods are running', Signed-off-by: Jeromy Cannon <[email protected]> commit 075051d Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:25:16 2025 +0000 removed todo in title: 'Check if cluster setup chart is installed', Signed-off-by: Jeromy Cannon <[email protected]> commit ad56068 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 16:10:16 2025 +0000 fixed minor issue Signed-off-by: Jeromy Cannon <[email protected]> commit 310a1cb Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 15:36:06 2025 +0000 patched NetworkCommand to work for test cases Signed-off-by: Jeromy Cannon <[email protected]> commit 98ba704 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 14:40:42 2025 +0000 fixed keysConfigBuilder Signed-off-by: Jeromy Cannon <[email protected]> commit 04dce8d Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 14:34:45 2025 +0000 fixed import error Signed-off-by: Jeromy Cannon <[email protected]> commit d15efd7 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 14:34:23 2025 +0000 fixed unit test cases Signed-off-by: Jeromy Cannon <[email protected]> commit 40200a7 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 13:26:24 2025 +0000 fixed some unit test cases Signed-off-by: Jeromy Cannon <[email protected]> commit d6ca20e Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 12:38:54 2025 +0000 Squashed commit of the following: commit 5b3d68a Author: Lenin Mehedy <[email protected]> Date: Wed Feb 12 23:37:56 2025 +1100 feat: handle multiple contexts during network deploy (#1369) Signed-off-by: Lenin Mehedy <[email protected]> commit ea24bc4 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 00:19:23 2025 +0000 more todos Signed-off-by: Jeromy Cannon <[email protected]> commit 71388dd Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 00:10:26 2025 +0000 pushing latest Signed-off-by: Jeromy Cannon <[email protected]> commit 209c2cd Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:53:15 2025 +0000 updated cluster ref flag description Signed-off-by: Jeromy Cannon <[email protected]> commit 1a0a337 Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:52:12 2025 +0000 renamed flag clusterName to clusterRef Signed-off-by: Jeromy Cannon <[email protected]> commit f4087bf Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:41:02 2025 +0000 saving progress Signed-off-by: Jeromy Cannon <[email protected]> commit 537fc1a Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 20:51:03 2025 +0000 set the networks deploy config with the contexts and the consensus nodes for later use Signed-off-by: Jeromy Cannon <[email protected]> commit e86e94c Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 20:07:53 2025 +0000 added base test for getContexts Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

leninmehedy added 2 commits February 12, 2025 16:08

feat: add support for multi-cluster values arg

88fac15

Signed-off-by: Lenin Mehedy <[email protected]>

fix: create storage secrets in all clusters

53604f2

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy changed the title ~~feat: handle multiple contexts~~ feat: handle multiple contexts during network deploy Feb 12, 2025

leninmehedy force-pushed the 01357-lenin branch from 5ad5083 to 81a6ec8 Compare February 12, 2025 08:06

jeromy-cannon reviewed Feb 12, 2025

View reviewed changes

src/commands/network.ts Outdated Show resolved Hide resolved

jeromy-cannon reviewed Feb 12, 2025

View reviewed changes

src/commands/network.ts Show resolved Hide resolved

leninmehedy added 2 commits February 12, 2025 20:09

fix: prepare namespace for each cluster

99436c3

Signed-off-by: Lenin Mehedy <[email protected]>

fix: add fixes based on review comments

8bec3e5

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 01357-lenin branch from 81a6ec8 to 8bec3e5 Compare February 12, 2025 10:49

leninmehedy marked this pull request as ready for review February 12, 2025 10:51

leninmehedy requested a review from a team as a code owner February 12, 2025 10:51

leninmehedy requested review from tomzhenghedera and removed request for tomzhenghedera February 12, 2025 10:51

fix: remove redundant import and fix log message

a36ff17

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 01357-lenin branch 2 times, most recently from 997ec50 to 6eaa35d Compare February 12, 2025 11:04

fix: rename valuesArg for config object

0d10e93

Signed-off-by: Lenin Mehedy <[email protected]>

leninmehedy force-pushed the 01357-lenin branch from 6eaa35d to 0d10e93 Compare February 12, 2025 11:09

jeromy-cannon approved these changes Feb 12, 2025

View reviewed changes

jeromy-cannon merged commit 5b3d68a into 01357-multi-cluster-network-deploy-part-3 Feb 12, 2025
15 of 37 checks passed

jeromy-cannon deleted the 01357-lenin branch February 12, 2025 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: handle multiple contexts during network deploy #1369

feat: handle multiple contexts during network deploy #1369

leninmehedy commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

feat: handle multiple contexts during network deploy #1369

feat: handle multiple contexts during network deploy #1369

Conversation

leninmehedy commented Feb 12, 2025 • edited Loading

Description

Related Issues

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Windows

leninmehedy commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading