-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: no need to test k8 copy functionality with large file #174
Conversation
This helps to avoid stability in tests Signed-off-by: Lenin Mehedy <[email protected]>
f6e5097
to
7731a99
Compare
Unit Test Results 1 files 16 suites 1m 11s ⏱️ Results for commit 7731a99. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
🎉 This PR is included in version 0.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This helps to avoid stability in tests
Description
This pull request changes the following:
This is because
copyTo
andcopyFrom
is a bit buggy for large file: #57. Currently it is making our tests unstable asbuild.hedera.com
URL is often slow and DDoS measure blocks our curl HEAD requests.We are currently fetching the build.zip file directly inside the container, so we really don't need to copy a large file to/from a container.
Related Issues