Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing file issues when running solo from npm install -g #734

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • fix missing file issues when running solo from npm install -g

Related Issues

Copy link
Contributor

Unit Test Results - Linux

  1 files   40 suites   6s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
123 runs  123 ✅ 0 💤 0 ❌

Results for commit ebbe79d.

Copy link
Contributor

Unit Test Results - Windows

  1 files   40 suites   22s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
123 runs  123 ✅ 0 💤 0 ❌

Results for commit ebbe79d.

Copy link
Contributor

github-actions bot commented Oct 23, 2024

E2E Test Report

 15 files   96 suites   55m 27s ⏱️
190 tests 190 ✅ 0 💤 0 ❌
193 runs  193 ✅ 0 💤 0 ❌

Results for commit ebbe79d.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3ed41201 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3ed4120) Report Missing Report Missing Report Missing
Head commit (ebbe79d) 13286 11472 86.35%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#734) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeromy-cannon jeromy-cannon merged commit c0c50ef into release/0.31 Oct 23, 2024
37 of 40 checks passed
@jeromy-cannon jeromy-cannon deleted the fix-missing-package-json branch October 23, 2024 09:41
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (7be759d) to head (ebbe79d).
Report is 24 commits behind head on release/0.31.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.31     #734       +/-   ##
=================================================
+ Coverage         66.11%   85.32%   +19.20%     
=================================================
  Files                38       38               
  Lines             14237    13286      -951     
  Branches            666     1229      +563     
=================================================
+ Hits               9413    11336     +1923     
+ Misses             4781     1826     -2955     
- Partials             43      124       +81     
Files with missing lines Coverage Δ
src/core/constants.ts 96.38% <100.00%> (ø)
src/core/helpers.ts 90.90% <100.00%> (ø)

... and 24 files with indirect coverage changes

Impacted file tree graph

swirlds-automation added a commit that referenced this pull request Oct 23, 2024
## [0.31.3](v0.31.2...v0.31.3) (2024-10-23)

### Bug Fixes

* fix missing file issues when running solo from npm install -g ([#734](#734)) ([c0c50ef](c0c50ef))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants