-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awsbase.ErrCodeEquals
, AWS SDK for Go v2 variant of helper in v2/awsv1shim/tfawserr
#524
Conversation
…v2/awsv1shim/tfawserr.
53ea247
to
1c3bdec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Will wait for final OK from @gdavison on correct location. |
tfawserr/awserr_test.go
Outdated
"testing" | ||
|
||
"github.com/aws/aws-sdk-go-v2/service/sts/types" | ||
"github.com/aws/aws-sdk-go/aws" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be github.com/aws/aws-sdk-go-v2/aws
to prevent the go.mod
diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy and paste :(
Community Note
Adds an AWS SDK for Go v2 variant of the
ErrCodeEquals
helper inv2/awsv1shim/tfawserr
.Not all services in the AWS SDK for Go v2 uses strongly-typed, modeled errors (EC2 is top of mind).
To support testing the returned API error code for these servies, add a variant of the
ErrCodeEquals
helper function defined inv2/awsv1shim/tfawserr
that uses thesmithy.APIError
interface.