Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Fixes panic when nonexistent node is queried #595

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fixes panic when nonexistent node is queried #595

merged 3 commits into from
Sep 7, 2023

Conversation

missylbytes
Copy link
Contributor

@missylbytes missylbytes commented Sep 6, 2023

Changes proposed in this PR:

Adds a nil check for the call back from Consul.

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@missylbytes missylbytes marked this pull request as ready for review September 6, 2023 20:08
Copy link
Contributor

@andrewstucki andrewstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a bit of the wording, but should be good to go when we get tests to pass.

Co-authored-by: Andrew Stucki <[email protected]>
@missylbytes missylbytes merged commit e75f184 into main Sep 7, 2023
@missylbytes missylbytes deleted the net-5321 branch September 7, 2023 13:29
missylbytes added a commit that referenced this pull request Sep 7, 2023
missylbytes added a commit that referenced this pull request Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants