Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Fixes panic when nonexistent node is queried #595

Merged
merged 3 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/595.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
Fix a nil pointer panic when Consul returns a literal "null" when checking catalog nodes.
```
3 changes: 3 additions & 0 deletions internal/k8s/service/resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,9 @@ func (r *backendResolver) findGlobalCatalogService(service *corev1.Service) (*Re
r.logger.Trace("error retrieving node services", "error", err, "node", node.Node)
return nil, err
}
if nodeWithServices == nil {
continue
}
if len(nodeWithServices.Services) == 0 {
continue
}
Expand Down