Inline function calls for testing

hashicorp · May 3, 2024 · 03d1d26 · 03d1d26
1 parent e7ec36e
commit 03d1d26
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/control-plane/api-gateway/controllers/gateway_controller_test.go b/control-plane/api-gateway/controllers/gateway_controller_test.go
@@ -8,6 +8,7 @@ import (
 	"testing"
 
 	mapset "github.com/deckarep/golang-set"
+
 	"github.com/hashicorp/consul-k8s/control-plane/api-gateway/common"
 	"github.com/hashicorp/consul-k8s/control-plane/api/v1alpha1"
 	"github.com/hashicorp/consul-k8s/control-plane/connect-inject/constants"
@@ -269,8 +270,7 @@ func TestTransformEndpoints(t *testing.T) {
 				allowK8sNamespacesSet: allowSet,
 			}
 
-			fn := controller.transformEndpoints
-			require.ElementsMatch(t, tt.expected, fn(context.Background(), tt.endpoints))
+			require.ElementsMatch(t, tt.expected, controller.transformEndpoints(context.Background(), tt.endpoints))
 		})
 	}
 }
@@ -409,8 +409,7 @@ func TestTransformHTTPRoute(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			controller := GatewayController{}
 
-			fn := controller.transformHTTPRoute
-			require.ElementsMatch(t, tt.expected, fn(context.Background(), tt.route))
+			require.ElementsMatch(t, tt.expected, controller.transformHTTPRoute(context.Background(), tt.route))
 		})
 	}
 }
@@ -549,8 +548,7 @@ func TestTransformTCPRoute(t *testing.T) {
 		t.Run(name, func(t *testing.T) {
 			controller := GatewayController{}
 
-			fn := controller.transformTCPRoute
-			require.ElementsMatch(t, tt.expected, fn(context.Background(), tt.route))
+			require.ElementsMatch(t, tt.expected, controller.transformTCPRoute(context.Background(), tt.route))
 		})
 	}
 }
@@ -635,8 +633,7 @@ func TestTransformSecret(t *testing.T) {
 				Client: fakeClient,
 			}
 
-			fn := controller.transformSecret
-			require.ElementsMatch(t, tt.expected, fn(context.Background(), tt.secret))
+			require.ElementsMatch(t, tt.expected, controller.transformSecret(context.Background(), tt.secret))
 		})
 	}
 }