Allow providing custom http port and using system roots to the connect-init container #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
approved these changes
Aug 26, 2022
thisisnotashwin
pushed a commit
that referenced
this pull request
Sep 19, 2022
jmurret
pushed a commit
that referenced
this pull request
Sep 27, 2022
ishustava
added a commit
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you have configured
externalServers.useSystemRootsor provided a different https port for external servers, we would ignore because we were hard-coding http port and were determining if TLS is enabled only if CA cert is set. That made sense when we were talking to clients, but now that we're talking to servers we need to account for those values so that the init container is correctly configured to talk to the serversHow I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: