Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial integration with consul-dataplane #1470

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Initial integration with consul-dataplane #1470

merged 1 commit into from
Sep 6, 2022

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Aug 31, 2022 •
edited
Loading

Changes proposed in this PR:

  • Initial integration to inject consul-dataplane instead of Envoy for service mesh containers

How I've tested this PR:
acceptance tests

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava changed the base branch from main to agentless-base August 31, 2022 19:04
@ishustava ishustava force-pushed the ishustava/consul-dataplane-connect branch 8 times, most recently from fa4f9e7 to 63b4d00 Compare September 1, 2022 22:27
@ishustava ishustava marked this pull request as ready for review September 2, 2022 16:28
@ishustava ishustava force-pushed the ishustava/consul-dataplane-connect branch from 63b4d00 to ebf65fd Compare September 2, 2022 16:46
ishustava
ishustava commented Sep 2, 2022
View reviewed changes
charts/consul/templates/connect-inject-deployment.yaml
-consul-k8s-image="{{ default .Values.global.imageK8S .Values.connectInject.image }}" \
-release-name="{{ .Release.Name }}" \
-release-namespace="{{ .Release.Namespace }}" \
-resource-prefix={{ template "consul.fullname" . }} \
-listen=:8080 \
-tls-server-name="server.{{ .Values.global.datacenter }}.{{ .Values.global.domain }}" \
Copy link
Contributor Author

@ishustava ishustava Sep 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we'll always need to pass TLS server name so that host verification works, but eventually consul-dataplane will infer that if the address is a DNS name.

ishustava
ishustava commented Sep 2, 2022
View reviewed changes
control-plane/subcommand/inject-connect/command.go
@@ -536,6 +537,7 @@ func (c *Command) Run(args []string) int {
ConsulHTTPPort: consulURL.Port(),
ConsulGRPCPort: "8502", // todo(ishustava): should be passed via flag
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be made configurable in a later PR

@ishustava ishustava force-pushed the ishustava/consul-dataplane-connect branch from ebf65fd to d532079 Compare September 2, 2022 17:55
t-eckert
t-eckert approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Be sure to comment out the places where the annotations you commented out are used.

@ishustava ishustava force-pushed the ishustava/consul-dataplane-connect branch from d532079 to dbe61c7 Compare September 2, 2022 18:37
thisisnotashwin
thisisnotashwin approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS EXCELLENT!!

@ishustava ishustava merged commit 8fb8b43 into agentless-base Sep 6, 2022
@ishustava ishustava deleted the ishustava/consul-dataplane-connect branch September 6, 2022 17:08
thisisnotashwin pushed a commit that referenced this pull request Sep 19, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
fb1f981
thisisnotashwin pushed a commit that referenced this pull request Sep 19, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
256d577
thisisnotashwin pushed a commit that referenced this pull request Sep 19, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
15c63fe
thisisnotashwin pushed a commit that referenced this pull request Sep 19, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
17c31f3
ishustava added a commit that referenced this pull request Sep 20, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
f710547
t-eckert pushed a commit that referenced this pull request Sep 20, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
94f4637
thisisnotashwin pushed a commit that referenced this pull request Sep 20, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
a467499
thisisnotashwin pushed a commit that referenced this pull request Sep 20, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
b27925c
ishustava added a commit that referenced this pull request Sep 20, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
deebb83
t-eckert pushed a commit that referenced this pull request Sep 21, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
83993dd
t-eckert pushed a commit that referenced this pull request Sep 21, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
cd9c726
t-eckert pushed a commit that referenced this pull request Sep 21, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
4a38715
t-eckert pushed a commit that referenced this pull request Sep 21, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
b0a2c92
thisisnotashwin pushed a commit that referenced this pull request Sep 22, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
e95516c
thisisnotashwin pushed a commit that referenced this pull request Sep 22, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
c0ed945
thisisnotashwin pushed a commit that referenced this pull request Sep 27, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
d7f8e5c
thisisnotashwin pushed a commit that referenced this pull request Sep 27, 2022
@ishustava @thisisnotashwin
agentless: initial integration with consul-dataplane (#1470)
5e28de7
jmurret pushed a commit that referenced this pull request Sep 27, 2022
@ishustava @jmurret
agentless: initial integration with consul-dataplane (#1470)
01f5317
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
9892498
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
47489d2
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
0ff9531
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
4509f2a
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
dbeb9ff
t-eckert pushed a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
871ab9a
ishustava added a commit that referenced this pull request Sep 28, 2022
@ishustava
agentless: initial integration with consul-dataplane (#1470)
4f4c368
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishustava @thisisnotashwin @t-eckert