Ingress Gateways integration with Agentless and Consul Dataplane #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
t-eckert
reviewed
Sep 27, 2022
t-eckert
reviewed
Sep 27, 2022
thisisnotashwin
force-pushed
the
ashwin/ingress-gateways
branch
from
21ac5b9 to
0464dfd
Compare
t-eckert
reviewed
Sep 27, 2022
thisisnotashwin
force-pushed
the
ashwin/ingress-gateways
branch
3 times, most recently
from
338d120 to
f557b64
Compare
ishustava
approved these changes
Sep 27, 2022
Comment on lines
-65
to
-71
| if !c.secure { | ||
| logger.Logf(t, "creating the %s namespace in Consul", testNamespace) | ||
| _, _, err := consulClient.Namespaces().Create(&api.Namespace{ | ||
| Name: testNamespace, | ||
| }, nil) | ||
| require.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
Oh nice! because endpoints controller will create the ns now, right?
| {{- if (and $root.Values.global.tls.enabled $root.Values.global.tls.enableAutoEncrypt) }} | ||
| {{- include "consul.getAutoEncryptClientCA" $root | nindent 8 }} | ||
| volumeMounts: | ||
| {{- if $root.Values.global.tls.enabled }} |
There was a problem hiding this comment.
this doesn't need to be mounted if external servers with use system roots is set
| {{- if $root.Values.global.tls.enabled }} | ||
| {{- if not (and $root.Values.externalServers.enabled $root.Values.externalServers.useSystemRoots) }} |
There was a problem hiding this comment.
I think we still need the this if condition
| -envoy-ready-bind-address=$POD_IP \ | ||
| -envoy-ready-bind-port=21000 \ | ||
| {{- if $root.Values.externalServers.enabled }} | ||
| -addresses={{ $root.Values.externalServers.hosts | first }} \ |
There was a problem hiding this comment.
we need to quote it so that command like -addresses="exec=..." works
Suggested change
| -addresses={{ $root.Values.externalServers.hosts | first }} \ | |
| -addresses={{ $root.Values.externalServers.hosts | first | quote }} \ |
thisisnotashwin
force-pushed
the
ashwin/ingress-gateways
branch
from
f557b64 to
453199c
Compare
- Use consul-dataplane instead of envoy.
thisisnotashwin
force-pushed
the
ashwin/ingress-gateways
branch
from
453199c to
57dfafc
Compare
ishustava
pushed a commit
that referenced
this pull request
Sep 28, 2022
- Use consul-dataplane instead of envoy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: