Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install gke-gcloud-auth-plugin into acceptance test image to fix warnings on GKE #1553

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Install gke-gcloud-auth-plugin into acceptance test image to fix warnings on GKE #1553

merged 2 commits into from
Sep 28, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Sep 28, 2022 •
edited
Loading

Changes proposed in this PR:

  • build and publish consul-helm-test image with gke-gloud-auth-plugin
  • use new image in CI

How I've tested this PR:
This passing nightly GKE test in my branch:

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@jmurret jmurret marked this pull request as ready for review September 28, 2022 23:36
@jmurret jmurret merged commit cad7d10 into main Sep 28, 2022
@jmurret jmurret deleted the jm/NET-1004 branch September 28, 2022 23:41
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurret @ndhanushkodi