Backport of NET-5947 Add NET_BIND_SERVICE capability in security context for api-gateway pod on OpenShift into release/1.2.x #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/api-gateway-net-bind-service/monthly-guiding-coral
branch
from
ff3f951 to
7d0a40e
Compare
|
|
nathancoleman
force-pushed
the
backport/api-gateway-net-bind-service/monthly-guiding-coral
branch
from
ae88b5b to
d07c133
Compare
nathancoleman
approved these changes
Oct 12, 2023
nathancoleman
force-pushed
the
backport/api-gateway-net-bind-service/monthly-guiding-coral
branch
from
f535f97 to
d07c133
Compare
|
Enterprise tests are failing due to issues that are being addressed in #3077 |
|
The PR referenced above was merged into |
…ext for api-gateway pod on OpenShift into release/1.2.x
nathancoleman
force-pushed
the
backport/api-gateway-net-bind-service/monthly-guiding-coral
branch
from
d07c133 to
40c4121
Compare
|
Rebasing now that #3082 has merged |
nathancoleman
deleted the
backport/api-gateway-net-bind-service/monthly-guiding-coral
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3070 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Why this change is needed:
This capability became a requirement for consul-dataplane, which api-gateway uses under the hood, as of hashicorp/consul-dataplane#238. Since the
securityContextcreated for each consul-dataplanePodwas not requesting theNET_BIND_SERVICEcapability specifically when deploying onto OpenShift, it was not being granted, and thePodwas failing to start with a permission denied error.Changes proposed in this PR:
NET_BIND_SERVICEcapability to thesecurityContextfor each api-gatewayPodHow I've tested this PR:
securityContextis always set appropriately onPodPodstarts up correctly nowHow I expect reviewers to test this PR:
Checklist:
Overview of commits