NET-5392 Replace dev dependencies w/ latest release tags #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
pr/no-changelog
DanStough
approved these changes
Nov 7, 2023
jm96441n
reviewed
Nov 7, 2023
nathancoleman
added
pr/no-backport
nathancoleman
force-pushed
the
NET-5392-remove-dev-deps
branch
from
e0a7532 to
3747aae
Compare
nathancoleman
force-pushed
the
NET-5392-remove-dev-deps
branch
from
3747aae to
667d390
Compare
The field was intentionally removed in hashicorp/consul#19186
nathancoleman
commented
Nov 7, 2023
| @@ -109,20 +108,6 @@ func TestProxyConfiguration_MatchesConsul(t *testing.T) { | |||
| JsonFormat: "jsonFormat", | |||
| TextFormat: "text format.", | |||
| }, | |||
| EnvoyExtensions: []*pbmesh.EnvoyExtension{ | |||
There was a problem hiding this comment.
This field was intentionally removed in hashicorp/consul#19186.
I've confirmed with @ishustava that it's safe to remove this code from the test.
NicoletaPopoviciu
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Some dependencies were previously pinned to utilize unreleased features of the Consul SDK.
This replaces those with the tagged releases containing those features
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: