-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test to match PreparedQuery SamenessGroup bugfix. #3387
Conversation
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the test, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked again, I think 1.2.x doesn't have the sameness tests so remove that label.
Also just a reminder not to merge the 1.3.x backport until after code freeze tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, 1.2.x does have the tests. All good! disregard my last comment
@hashi-derek, echoing what @wilkermichael said. There is a code freeze on |
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
…into release/1.2.x (#3392) Update test to match PreparedQuery SamenessGroup bugfix. (#3387) Update test to assert the fixed behavior of PR #7773 in Consul Enterprise. Co-authored-by: Derek Menteer <[email protected]>
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
hashicorp/consul#19970