Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to match PreparedQuery SamenessGroup bugfix. #3387

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

hashi-derek
Copy link
Member

@hashi-derek hashi-derek commented Dec 18, 2023

Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.

hashicorp/consul#19970

Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
@hashi-derek hashi-derek added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. labels Dec 18, 2023
@hashi-derek hashi-derek marked this pull request as ready for review December 18, 2023 17:37
Copy link
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the test, looks good!

@wilkermichael wilkermichael self-requested a review December 18, 2023 18:30
Copy link
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked again, I think 1.2.x doesn't have the sameness tests so remove that label.

Also just a reminder not to merge the 1.3.x backport until after code freeze tomorrow.

Copy link
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, 1.2.x does have the tests. All good! disregard my last comment

@t-eckert
Copy link
Contributor

@hashi-derek, echoing what @wilkermichael said. There is a code freeze on 1.{1-3}.x for now so please do not merge those backports.

hashi-derek added a commit that referenced this pull request Dec 18, 2023
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
hashi-derek added a commit that referenced this pull request Dec 18, 2023
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
hashi-derek added a commit that referenced this pull request Dec 19, 2023
…into release/1.2.x (#3392)

Update test to match PreparedQuery SamenessGroup bugfix. (#3387)

Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.

Co-authored-by: Derek Menteer <[email protected]>
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
Update test to assert the fixed behavior of PR #7773 in Consul Enterprise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.2.x This release branch is no longer active. backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants