Backport of [NET-6465] Consider init container resources when determining if existing + desired deployments are equal into release/1.2.x #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/consider-init-containers-when-diffing/positively-closing-fly
branch
from
139e7d2 to
1ebc86e
Compare
nathancoleman
approved these changes
Feb 7, 2024
nathancoleman
deleted the
backport/consider-init-containers-when-diffing/positively-closing-fly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3575 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Note
This is a followup to #3531
Changes proposed in this PR
When there's an existing
Deploymentin the cluster and we're comparing it against our desired state to determine if there's an update to be made, the comparison needs to consider whether the resources for the init container(s) have been updated.How I've tested this PR
Gatewayon a cluster havinghelm install-ed with or without a value for.Values.connectInject.initContainer.resources..Values.connectInject.initContainer.resourcesandhelm upgradePodtriggers an update to the resources of the init container to match your values. This cycling requirement is consistent with how regular service Deployments in Consul mesh behave due to needing some action to trigger the reconciliation process.How I expect reviewers to test this PR
See above
Checklist
Overview of commits