Backport of NET-6878: Remove finalizers from CRDs during test resource cleanup into release/1.2.x #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/cleanup_remove_finalizers/blatantly-set-basilisk
branch
from
3cceb96 to
5916b11
Compare
NiniOak
approved these changes
Mar 14, 2024
hc-github-team-consul-core
merged commit 84740b8
into
release/1.2.x
23 of 47 checks passed
hc-github-team-consul-core
deleted the
backport/cleanup_remove_finalizers/blatantly-set-basilisk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3739 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
At times, CRDs created as part of the test suite are not cleaned up properly causing the test to timeout and run for a really long time
How I've tested this PR
CI should pass
How I expect reviewers to test this PR
CI should pass
Checklist
Overview of commits