Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-6878: Remove finalizers from CRDs during test resource cleanup into release/1.4.x #3749

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3739 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

At times, CRDs created as part of the test suite are not cleaned up properly causing the test to timeout and run for a really long time

  • Switch from retrier based on time to a counter based retries for fast fail
  • Add goroutine to the remove finalizers, if "delete" resource command is called

How I've tested this PR

CI should pass

How I expect reviewers to test this PR

CI should pass

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/cleanup_remove_finalizers/centrally-outgoing-teal branch from f19ee52 to 5bfbd8e Compare March 14, 2024 17:37
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) March 14, 2024 17:37
@hc-github-team-consul-core hc-github-team-consul-core merged commit 02aefa8 into release/1.4.x Mar 14, 2024
38 of 49 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/cleanup_remove_finalizers/centrally-outgoing-teal branch March 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants