remove catalogv2 implementation and tests #4061
Conversation
rboyer
force-pushed
the
rboyer/remove-catalogv2-impl
branch
from
fb2e1a9 to
d053184
Compare
rboyer
added
pr/no-changelog
|
Pretty sure now I have had all of the flavors of acceptance test pass at least once, so I probably didn't over-delete anything this time. |
| @@ -97,11 +99,32 @@ control-plane-fips-dev-docker: ## Build consul-k8s-control-plane FIPS dev Docker | |||
|
|
|||
| .PHONY: control-plane-test | |||
| control-plane-test: ## Run go test for the control plane. | |||
| cd control-plane; go test ./... | |||
| ifeq ("$(GOTESTSUM_PATH)","") | |||
There was a problem hiding this comment.
I cribbed this conditional gotestsum running approach from the consul main repo to help when I was running and re-running the normal tests.
There was a problem hiding this comment.
Interesting, so we were including the V2 CRDs all of the time, not just when resource-apis was enabled? 🤔 . No action required.
There was a problem hiding this comment.
This namespace controller only appears in v2controllers.go. I think we can remove the whole directory, correct?
🚀
- Remove all direct plumbing related to the resource-apis and v2tenancy experiments - Remove all remaining dead code pertaining to the remainder of Consul resources (all experimental) - Remove all tests of the above
rboyer
force-pushed
the
rboyer/remove-catalogv2-impl
branch
from
4462bac to
7c192b6
Compare
zalimeni
added
backport/1.4.x
backport/1.5.x
backport/1.6.x
zalimeni
removed
backport/1.4.x
backport/1.5.x
backport/1.6.x
|
Removing labels for now but wondering whether we should backport this change to 1.4-1.6 to avoid discrepancies in backports of other changes. |
Changes proposed in this PR
resource-apisandv2tenancyexperimentshttps://hashicorp.atlassian.net/browse/NET-9089