improve child logging messages

Removed 'died' terminology as it is non-standard terminology and is just wrong when the child exits successfully.
hashicorp · Sep 29, 2022 · 7d21c8a · 7d21c8a
1 parent b722e29
commit 7d21c8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/manager/errors.go b/manager/errors.go
@@ -24,7 +24,7 @@ func NewErrChildDied(c int) *ErrChildDied {
 
 // Error implements the error interface.
 func (e *ErrChildDied) Error() string {
-	return fmt.Sprintf("child process died with exit code %d", e.code)
+	return fmt.Sprintf("child process exited with code %d", e.code)
 }
 
 // ExitStatus implements the ErrExitable interface.

diff --git a/manager/runner.go b/manager/runner.go
@@ -244,7 +244,7 @@ func (r *Runner) Start() {
 			log.Printf("[INFO] (runner) waiting for child process to exit")
 			select {
 			case c := <-childExitCh:
-				log.Printf("[INFO] (runner) child process died")
+				log.Printf("[INFO] (runner) child process exited")
 				r.ErrCh <- NewErrChildDied(c)
 				return
 			case <-r.DoneCh:
@@ -348,7 +348,7 @@ func (r *Runner) Start() {
 					log.Printf("[INFO] (runner) waiting for child process to exit")
 					select {
 					case c := <-childExitCh:
-						log.Printf("[INFO] (runner) child process died")
+						log.Printf("[INFO] (runner) child process exited")
 						r.ErrCh <- NewErrChildDied(c)
 						return
 					case <-r.DoneCh:
@@ -410,7 +410,7 @@ func (r *Runner) Start() {
 			delete(r.quiescenceMap, tmpl.ID())
 
 		case c := <-childExitCh:
-			log.Printf("[INFO] (runner) child process died")
+			log.Printf("[INFO] (runner) child process exited")
 			r.ErrCh <- NewErrChildDied(c)
 			return